r112882 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112881‎ | r112882 | r112883 >
Date:12:30, 2 March 2012
Author:siebrand
Status:resolved
Tags:i18nreview 
Comment:
* Follow-up r112878: Fix bad copy-paste.
* Add todos for preventing duplicate log entries on page reload or playing around with the CGI parameters.

internationalization/#382
Modified paths:
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
@@ -88,11 +88,13 @@
8989
9090 if ( $action === 'encourage' ) {
9191 $dbw->delete( $table, $row, __METHOD__ );
92 - $logger->addEntry( 'encourage', $page->getTitle(), null, array( serialize( $params ) ) );
 92+ // @todo Check if page is currently actually discouraged to prevent duplicate log entries.
 93+ $logger->addEntry( 'encourage', $title, null, array( serialize( $params ) ) );
9394 } else {
9495 $index = array( 'tgr_group', 'tgr_lang' );
9596 $dbw->replace( $table, array( $index ), $row, __METHOD__ );
96 - $logger->addEntry( 'discourage', $page->getTitle(), null, array( serialize( $params ) ) );
 97+ // @todo Check if page is currently actually discouraged to prevent duplicate log entries.
 98+ $logger->addEntry( 'discourage', $title, null, array( serialize( $params ) ) );
9799 }
98100
99101 $this->listPages();

Sign-offs

UserFlagDate
Nikerabbitinspected22:55, 2 March 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112887Fix a copy-paste mistake in r112882...santhosh13:18, 2 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112878Logging for encouraged/discouraged marking to Special:Log/pagetranslation on ...siebrand12:05, 2 March 2012

Status & tagging log