r112737 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112736‎ | r112737 | r112738 >
Date:23:25, 29 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Remove extra unused parameters to save warnings


4 Warning: Missing argument 3 for ApiViewRatingsArticleFeedbackv5::fetchRollup(), called in /usr/local/apache/common-local/php-1.19/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php
on line 38 and defined in /usr/local/apache/common-local/php-1.19/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php on line 63
4 Warning: Missing argument 2 for ApiViewRatingsArticleFeedbackv5::fetchRollup(), called in /usr/local/apache/common-local/php-1.19/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php
on line 38 and defined in /usr/local/apache/common-local/php-1.19/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php on line 63
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php
——@@ -56,11 +56,9 @@
5757 * Pulls a rollup row
5858 *
5959 * @param $pageId int the page id
60 - * @param $revisionLimit int go back only to this revision
61 - * @param $type string the type of row to fetch ('page' or 'revision')
6260 * @return array the rollup rows
6361 */
64 - private function fetchRollup( $pageId, $revisionLimit, $type ) {
 62+ private function fetchRollup( $pageId ) {
6563 $dbr = wfGetDB( DB_SLAVE );
6664 $where = array();
6765 $table = 'article_feedback_ratings_rollup';

Follow-up revisions

RevisionCommit summaryAuthorDate
r112738Do r112737 to 1.18wmf1 incase we end up needing to go backreedy23:28, 29 February 2012

Status & tagging log