r112538 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112537‎ | r112538 | r112539 >
Date:23:00, 27 February 2012
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Dummy proof TempFSFile purging when the constructor is used directly to avoid data loss.
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/TempFSFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/TempFSFile.php
@@ -11,7 +11,7 @@
1212 * @ingroup FileBackend
1313 */
1414 class TempFSFile extends FSFile {
15 - protected $canDelete = true; // garbage collect the temp file
 15+ protected $canDelete = false; // bool; garbage collect the temp file
1616
1717 /** @var Array of active temp files to purge on shutdown */
1818 protected static $instances = array();
@@ -41,6 +41,7 @@
4242 }
4343 }
4444 $tmpFile = new self( $path );
 45+ $tmpFile->canDelete = true; // safely instantiated
4546 return $tmpFile;
4647 }
4748

Follow-up revisions

RevisionCommit summaryAuthorDate
r112647MFT r112384, r112400, r112408, r112451, r112456, r112474, r112526, r112533, r...reedy21:21, 28 February 2012

Comments

#Comment by Hashar (talk | contribs)   16:31, 28 February 2012

1.19wmf1 too ? :)

Status & tagging log