r112381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112380‎ | r112381 | r112382 >
Date:01:43, 25 February 2012
Author:aaron
Status:ok
Tags:
Comment:
More file streaming related profiling
Modified paths:
  • /trunk/phase3/includes/StreamFile.php (modified) (history)
  • /trunk/phase3/includes/filerepo/backend/FileBackend.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/FileBackend.php
@@ -1267,7 +1267,9 @@
12681268 if ( $res == StreamFile::NOT_MODIFIED ) {
12691269 // do nothing; client cache is up to date
12701270 } elseif ( $res == StreamFile::READY_STREAM ) {
 1271+ wfProfileIn( __METHOD__ . '-send' );
12711272 $status = $this->doStreamFile( $params );
 1273+ wfProfileOut( __METHOD__ . '-send' );
12721274 } else {
12731275 $status->fatal( 'backend-fail-stream', $params['src'] );
12741276 }
Index: trunk/phase3/includes/StreamFile.php
@@ -29,7 +29,9 @@
3030 if ( $res == self::NOT_MODIFIED ) {
3131 $ok = true; // use client cache
3232 } elseif ( $res == self::READY_STREAM ) {
 33+ wfProfileIn( __METHOD__ . '-send' );
3334 $ok = readfile( $fname );
 35+ wfProfileOut( __METHOD__ . '-send' );
3436 } else {
3537 $ok = false; // failed
3638 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112382MFT r112381aaron01:44, 25 February 2012

Status & tagging log