r112352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112351‎ | r112352 | r112353 >
Date:20:30, 24 February 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
avoid test suite file leaks
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/filerepo/FileBackendTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/filerepo/FileBackendTest.php
@@ -200,6 +200,7 @@
201201 $this->backend = $this->multiBackend;
202202 $this->tearDownFiles();
203203 $this->doTestStore( $op );
 204+ $this->filesToPrune[] = $op['src']; # avoid file leaking
204205 $this->tearDownFiles();
205206 }
206207
@@ -662,6 +663,7 @@
663664 $this->backend = $this->multiBackend;
664665 $this->tearDownFiles();
665666 $this->doTestConcatenate( $op, $srcs, $srcsContent, $alreadyExists, $okStatus );
 667+ $this->filesToPrune[] = $op['dst']; # avoid file leaking
666668 $this->tearDownFiles();
667669 }
668670

Follow-up revisions

RevisionCommit summaryAuthorDate
r112354MFT to REL1_19 fix tests leaking files...hashar20:38, 24 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   20:42, 24 February 2012

Why not just move that filesToPrune[] code to the doConcatenate and doStore functions? I don't know why it wasn't there to begin with.

Status & tagging log