r112351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112350‎ | r112351 | r112352 >
Date:20:28, 24 February 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r112215;
Modified paths:
  • /trunk/extensions/SemanticResultFormats/Gallery/resources/ext.srf.jcarousel.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Gallery/resources/ext.srf.jcarousel.js
@@ -13,24 +13,20 @@
1414
1515 // Bind individual elements containing class jcarousel as the plug-in
1616 // requires different id's
17 - $(".jcarousel").each(function() {
18 - var galleryId = "#" + $(this).closest(".jcarousel").attr("id"),
19 - v_vertical = ( $( this ).attr( 'vertical' ) === 'true'), // Value is either true or false
20 - v_rtl = ( $( this ).attr( 'rtl' ) === 'true'); // Value is either true or false
21 - //console.log(galleryId);
 17+ $(".jcarousel").each(function() {
 18+ var $this = $( this );
2219
2320 // Display carousel only after js is loaded and is ready otherwise display=none
24 - $( this ).show();
 21+ $this.show();
2522
2623 // Call the jcarousel plug-in
27 - $( this ).jcarousel({
28 - scroll: parseInt($( this ).attr( 'scroll' ) ), // Number of items to be scrolled
29 - visible: parseInt($( this ).attr( 'visible' ) ), // calculated and set visible elements
30 - wrap: $( this ).attr( 'wrap' ), // Options are "first", "last", "both" or "circular"
31 - vertical: v_vertical, // Whether the carousel appears in horizontal or vertical orientation
32 - rtl: v_rtl // Directionality
 24+ $this.jcarousel( {
 25+ scroll: parseInt( $this.attr( 'scroll' ), 10 ), // Number of items to be scrolled
 26+ visible: parseInt( $this.attr( 'visible' ), 10 ), // calculated and set visible elements
 27+ wrap: $this.attr( 'wrap' ), // Options are "first", "last", "both" or "circular"
 28+ vertical: $this.attr( 'vertical' ) === 'true', // Whether the carousel appears in horizontal or vertical orientation
 29+ rtl: $this.attr( 'rtl' ) === 'true' // Directionality
3330 } );
34 -
3531 } );
3632
3733 } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112215bug 34411 patch by MWJames, somewhat modifiedjeroendedauw16:28, 23 February 2012