r112253 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112252‎ | r112253 | r112254 >
Date:22:26, 23 February 2012
Author:brion
Status:ok
Tags:
Comment:
* (bug 34652) Fix regression in UploadWizard custom language list

Fixes regression in r107641 which removed the server portion of the URL from what's passed into mediawiki.loader.load, causing the relative URL not to be recognized as an absolute includable URL
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -51,7 +51,7 @@
5252
5353 // load list of languages so we'll have it ready when description interfaces are created
5454 // XXX replace this code once any of the following bugs are fixed: 25845, 27535, 27561
55 - var languageHandlerUrl = mw.util.wikiScript() + '?' + $.param( { 'title': 'MediaWiki:LanguageHandler.js', 'action': 'raw', 'ctype': 'text/javascript' } );
 55+ var languageHandlerUrl = mw.config.get( 'wgServer' ) + mw.util.wikiScript() + '?' + $.param( { 'title': 'MediaWiki:LanguageHandler.js', 'action': 'raw', 'ctype': 'text/javascript' } );
5656 mw.loader.load( languageHandlerUrl );
5757
5858 // remove first spinner

Sign-offs

UserFlagDate
Reedytested15:50, 5 March 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112256MFT r112248, r112250, r112253reedy22:32, 23 February 2012
r113049MFT r112229, r112248, r112253, r112260, r112758reedy17:46, 5 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107641[UploadWizard] Uncaught ReferenceError: wgSiteName is not definedkrinkle18:31, 30 December 2011

Status & tagging log