r112229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112228‎ | r112229 | r112230 >
Date:19:28, 23 February 2012
Author:brion
Status:reverted
Tags:gerritmigration 
Comment:
May or may not help with bug 34601 UW mispositioned file control - still can't reproduce this on a local install.

Force UploadWizard styles to load early.... there *is* HTML at output time, though it's "hidden" until some additional styling is applied to it.
Sometimes in Chrome some of the HTML flashes briefly without style, which seems to be when we pick up the wrong positioning... this hopefully will avoid that possibility by ensuring the styles are preloaded.
Modified paths:
  • /trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
@@ -73,6 +73,7 @@
7474 $this->addJsVars( $subPage );
7575
7676 // dependencies (css, js)
 77+ $out->addModuleStyles( 'ext.uploadWizard' );
7778 $out->addModules( 'ext.uploadWizard' );
7879
7980 // where the uploadwizard will go

Follow-up revisions

RevisionCommit summaryAuthorDate
r112235MFT r112229reedy19:58, 23 February 2012
r112248Another stab at bug 34601: UploadWizard positioning issues with hidden file i...brion22:04, 23 February 2012
r113049MFT r112229, r112248, r112253, r112260, r112758reedy17:46, 5 March 2012
r114400Revert r112166, r112229, r112248, r113584, r113591, r114349: unreviewed revis...catrope20:21, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112166Semi-wild stab at bug 34601: 'drop media file to donate here' sometimes silen...brion23:50, 22 February 2012

Status & tagging log