r112066 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112065‎ | r112066 | r112067 >
Date:00:00, 22 February 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Move parameters were backwards

Ping r112061
Modified paths:
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogFormatter.php
——@@ -165,11 +165,11 @@
166166 switch( $entry->getSubtype() ) {
167167 case 'move':
168168 $movesource = $parameters['4::target'];
169 - $text = wfMsg( '1movedto2', $movesource, $target );
 169+ $text = wfMsg( '1movedto2', $target, $movesource );
170170 break;
171171 case 'move_redir':
172172 $movesource = $parameters['4::target'];
173 - $text = wfMsg( '1movedto2_redir', $movesource, $target );
 173+ $text = wfMsg( '1movedto2_redir', $target, $movesource );
174174 break;
175175 case 'move-noredirect':
176176 break;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112073MFT r112045, r112046, r112049, r112061, r112062, r112063, r112065, r112066, r...reedy00:54, 22 February 2012
r112639MFT r112045, r112046, r112049, r112061, r112066, r112079, r112128reedy21:08, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112061Bug 34508 - [Regression] IRC string output for log messages no longer compatible...reedy23:38, 21 February 2012

Comments

#Comment by Krinkle (talk | contribs)   11:16, 24 February 2012

Hm.. really ? 

 	4737	+ '1movedto2'                   => 'moved [[$1]] to [[$2]]',
 	4738	+ '1movedto2_redir'             => 'moved [[$1]] to [[$2]] over redirect',

(r112061)

#Comment by Krinkle (talk | contribs)   11:17, 24 February 2012

Oh, I guess it's just a bad variable name. Keeping fixme for now, if anyone has confirmed it live to be right, feel free to re-mark ok.

#Comment by Reedy (talk | contribs)   14:56, 24 February 2012

Indeed, I tested it on my wiki, hence knowing they were displayed wrong

Status & tagging log