r112049 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112048‎ | r112049 | r112050 >
Date:21:54, 21 February 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Effectively revert r112042

Followup r112045, remove the irc key name changes
Modified paths:
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogFormatter.php
@@ -149,7 +149,6 @@
150150 * @return string text
151151 */
152152 public function getIRCActionText() {
153 - $this->irctext = true;
154153 $this->plaintext = true;
155154 $text = $this->getActionText();
156155
@@ -171,7 +170,6 @@
172171 }
173172
174173 $this->plaintext = false;
175 - $this->irctext = false;
176174 return $text;
177175 }
178176
@@ -218,14 +216,8 @@
219217 protected function getMessageKey() {
220218 $type = $this->entry->getType();
221219 $subtype = $this->entry->getSubtype();
222 - if( $this->irctext ) {
223 - $key = "logentry-irc-$type-$subtype";
224 - }
225 - else {
226 - $key = "logentry-$type-$subtype";
227 - }
228220
229 - return $key;
 221+ return "logentry-$type-$subtype";
230222 }
231223
232224 /**
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4718,27 +4718,23 @@
47194719 'newuserlog-byemail' => 'password sent by e-mail',
47204720
47214721 # For IRC, see bug 34508. Do not change
4722 -'logentry-irc-delete-delete' => 'deleted "$3"',
4723 -'logentry-irc-delete-restore' => 'restored "$3"',
4724 -'logentry-irc-delete-event' => '$1 changed visibility of {{PLURAL:$5|a log event|$5 log events}} on $3: $4',
4725 -'logentry-irc-delete-revision' => '$1 changed visibility of {{PLURAL:$5|a revision|$5 revisions}} on page $3: $4',
4726 -'logentry-irc-delete-event-legacy' => '$1 changed visibility of log events on $3',
4727 -'logentry-irc-delete-revision-legacy' => '$1 changed visibility of revisions on page $3',
4728 -'logentry-irc-suppress-delete' => '$1 suppressed page $3',
4729 -'logentry-irc-suppress-event' => '$1 secretly changed visibility of {{PLURAL:$5|a log event|$5 log events}} on $3: $4',
4730 -'logentry-irc-suppress-revision' => '$1 secretly changed visibility of {{PLURAL:$5|a revision|$5 revisions}} on page $3: $4',
4731 -'logentry-irc-suppress-event-legacy' => '$1 secretly changed visibility of log events on $3',
4732 -'logentry-irc-suppress-revision-legacy' => '$1 secretly changed visibility of revisions on page $3',
4733 -'logentry-irc-move-move' => '$1 moved page $3 to $4',
4734 -'logentry-irc-move-move-noredirect' => '$1 moved page $3 to $4 without leaving a redirect',
4735 -'logentry-irc-move-move_redir' => 'moved $3 to $4 over redirect',
4736 -'logentry-irc-move-move_redir-noredirect' => '$1 moved page $3 to $4 over a redirect without leaving a redirect',
4737 -'logentry-irc-patrol-patrol' => '$1 marked revision $4 of page $3 patrolled',
4738 -'logentry-irc-patrol-patrol-auto' => '$1 automatically marked revision $4 of page $3 patrolled',
4739 -'logentry-irc-newusers-newusers' => '$1 created a user account',
4740 -'logentry-irc-newusers-create' => '$1 created a user account',
4741 -'logentry-irc-newusers-create2' => '$1 created a user account $3',
4742 -'logentry-irc-newusers-autocreate' => 'Account $1 was created automatically',
 4722+'revdelete-logentry' => 'changed revision visibility of "[[$1]]"',
 4723+'logdelete-logentry' => 'changed event visibility of "[[$1]]"',
 4724+'revdelete-content' => 'content',
 4725+'revdelete-summary' => 'edit summary',
 4726+'revdelete-uname' => 'username',
 4727+'revdelete-restricted' => 'applied restrictions to administrators',
 4728+'revdelete-unrestricted' => 'removed restrictions for administrators',
 4729+'revdelete-hid' => 'hid $1',
 4730+'revdelete-unhid' => 'unhid $1',
 4731+'revdelete-log-message' => '$1 for $2 {{PLURAL:$2|revision|revisions}}',
 4732+'logdelete-log-message' => '$1 for $2 {{PLURAL:$2|event|events}}',
 4733+'deletedarticle' => 'deleted "[[$1]]"',
 4734+'suppressedarticle' => 'suppressed "[[$1]]"',
 4735+'undeletedarticle' => 'restored "[[$1]]"',
 4736+'patrol-log-line' => 'marked $1 of $2 patrolled $3',
 4737+'patrol-log-auto' => '(automatic)',
 4738+'patrol-log-diff' => 'revision $1',
47434739
47444740 # Feedback
47454741 'feedback-bugornote' => 'If you are ready to describe a technical problem in detail please [$1 report a bug].

Sign-offs

UserFlagDate
Nikerabbitinspected07:47, 22 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112073MFT r112045, r112046, r112049, r112061, r112062, r112063, r112065, r112066, r...reedy00:54, 22 February 2012
r112639MFT r112045, r112046, r112049, r112061, r112066, r112079, r112128reedy21:08, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112042Part 1 for bug 34508, commit all the messages added in patch 3reedy21:12, 21 February 2012
r112045First merge of the rest of the code from bug 34508 patch 1 and patch 3reedy21:26, 21 February 2012

Comments

#Comment by Siebrand (talk | contribs)   21:57, 21 February 2012

So what's the idea now? Will we be stuck with bc for log entries to irc forever? Only a few log entries have been converted to use the new log class so far, many should follow.

#Comment by Reedy (talk | contribs)   22:28, 21 February 2012

The main issue is is that it wasn't realised/remembered that the messages had changed.

As such, no one gave bot operators/writers any sort of heads up

The intention (hopefully), is to get a back compat hack in place, and give people a chance to fix their bots in time for a planned migration on date X, when we'll revert back to the newer code...

Status & tagging log