r111895 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111894‎ | r111895 | r111896 >
Date:22:31, 19 February 2012
Author:amire80
Status:resolved
Tags:i18nreview 
Comment:
Added one more test for Hebrew and changed Russian words to be more realistic.
Modified paths:
  • /branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js (modified) (history)

Diff [purge]

Index: branches/jsgrammar/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
@@ -12,7 +12,7 @@
1313 test: [],
1414 }, options);
1515 // The test works only if the content language is opt.language
16 - // because it require [lang].js to be loaded.
 16+ // because it requires [lang].js to be loaded.
1717 if( mw.config.get ( 'wgContentLanguage' ) === opt.language ) {
1818 test( "-- Grammar Test for "+ opt.language, function() {
1919 expect( opt.test.length);
@@ -37,7 +37,8 @@
3838 { word: "ויקיפדיה", grammarForm: 'prefixed', expected: "וויקיפדיה", description: 'Grammar test for Hebrew, Duplicate the "Waw" if prefixed' },
3939 { word: "וולפגנג", grammarForm: 'prefixed', expected: "וולפגנג", description: 'Grammar test for Hebrew, Duplicate the "Waw" if prefixed, but not if it is already duplicated.' },
4040 { word: "הקובץ", grammarForm: 'prefixed', expected: "קובץ", description: 'Grammar test for Hebrew, Remove the "He" if prefixed' },
41 - { word: 'wikipedia', grammarForm: 'תחילית', expected: '־wikipedia', description: 'Grammar test for Hebrew, Add a hyphen (maqaf) if non-Hebrew letters' }
 41+ { word: 'Wikipedia', grammarForm: 'תחילית', expected: '־Wikipedia', description: 'Grammar test for Hebrew, Add a hyphen (maqaf) before non-Hebrew letters' }
 42+ { word: '1995', grammarForm: 'תחילית', expected: '־1995', description: 'Grammar test for Hebrew, Add a hyphen (maqaf) before numbers' }
4243 ]
4344 });
4445
@@ -75,11 +76,11 @@
7677 mw.language.grammartest({
7778 language: 'ru',
7879 test: [
79 - { word: 'честь', grammarForm: 'genitive', expected: 'честя', description: 'Grammar test for Russian, genitive case' },
80 - { word: 'проведения', grammarForm: 'genitive', expected: 'проведении', description: 'Grammar test for Russian, genitive case' },
81 - { word: 'Оснабрюка', grammarForm: 'genitive', expected: 'Оснабрюки', description: 'Grammar test for Russian, genitive case' },
82 - { word: 'почти', grammarForm: 'genitive', expected: 'почтей', description: 'Grammar test for Russian, genitive case' },
83 - { word: 'годы', grammarForm: 'genitive', expected: 'годов', description: 'Grammar test for Russian, genitive case' },
 80+ { word: 'тесть', grammarForm: 'genitive', expected: 'тестя', description: 'Grammar test for Russian, genitive case' },
 81+ { word: 'привилегия', grammarForm: 'genitive', expected: 'привилегии', description: 'Grammar test for Russian, genitive case' },
 82+ { word: 'установка', grammarForm: 'genitive', expected: 'установки', description: 'Grammar test for Russian, genitive case' },
 83+ { word: 'похоти', grammarForm: 'genitive', expected: 'похотей', description: 'Grammar test for Russian, genitive case' },
 84+ { word: 'доводы', grammarForm: 'genitive', expected: 'доводов', description: 'Grammar test for Russian, genitive case' },
8485 { word: 'песчаник', grammarForm: 'genitive', expected: 'песчаника', description: 'Grammar test for Russian, genitive case' }
8586 ]
8687 });

Sign-offs

UserFlagDate
Nikerabbitinspected07:32, 20 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r111911Fix a missing a comma in r111895santhosh05:43, 20 February 2012

Status & tagging log