r111894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111893‎ | r111894 | r111895 >
Date:22:29, 19 February 2012
Author:ialex
Status:ok
Tags:
Comment:
Call directly numRows() on the result object instead of DatabaseBase::numRows()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -286,7 +286,7 @@
287287 wfRunHooks('SpecialWatchlistQuery', array(&$conds,&$tables,&$join_conds,&$fields) );
288288
289289 $res = $dbr->select( $tables, $fields, $conds, __METHOD__, $options, $join_conds );
290 - $numRows = $dbr->numRows( $res );
 290+ $numRows = $res->numRows();
291291
292292 /* Start bottom header */
293293

Status & tagging log