r111323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111322‎ | r111323 | r111324 >
Date:19:40, 12 February 2012
Author:hashar
Status:ok
Tags:
Comment:
revert core part of r111231

That one removed wfLoadExtensionMessages() . We do not want to break
back compatiliblity right now.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/PageQueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -3567,6 +3567,16 @@
35683568 }
35693569
35703570 /**
 3571+ * Load an extension messages file
 3572+ *
 3573+ * @deprecated since 1.16, warnings in 1.18, remove in 1.20
 3574+ * @codeCoverageIgnore
 3575+ */
 3576+function wfLoadExtensionMessages() {
 3577+ wfDeprecated( __FUNCTION__, '1.16' );
 3578+}
 3579+
 3580+/**
35713581 * Get a platform-independent path to the null file, e.g. /dev/null
35723582 *
35733583 * @return string
Index: trunk/phase3/includes/PageQueryPage.php
@@ -6,6 +6,7 @@
77 * @ingroup SpecialPage
88 */
99 abstract class PageQueryPage extends QueryPage {
 10+
1011 /**
1112 * Format the result as a simple link to the page
1213 *
@@ -15,14 +16,11 @@
1617 */
1718 public function formatResult( $skin, $row ) {
1819 global $wgContLang;
19 -
2020 $title = Title::makeTitleSafe( $row->namespace, $row->title );
2121 $text = $row->title;
22 -
2322 if ( $title instanceof Title ) {
2423 $text = $wgContLang->convert( $title->getPrefixedText() );
2524 }
26 -
2725 return Linker::linkKnown( $title, htmlspecialchars( $text ) );
2826 }
2927 }
Index: trunk/phase3/RELEASE-NOTES-1.20
@@ -15,7 +15,6 @@
1616 === New features in 1.20 ===
1717 * Added TitleIsKnown hook which gets called when determining if a page exists.
1818 * (bug 32341) Add upload by URL domain limitation.
19 -* wfLoadExtensionMessages() was removed. Deprecated in 1.16, removed in 1.20.
2019
2120 === Bug fixes in 1.20 ===
2221 * (bug 30245) Use the correct way to construct a log page title.

Sign-offs

UserFlagDate
Nikerabbitinspected07:07, 13 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111231* Remove last remaining traces of wfLoadExtensionMessages()....siebrand12:17, 11 February 2012

Status & tagging log