r111322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111321‎ | r111322 | r111323 >
Date:19:33, 12 February 2012
Author:hashar
Status:ok
Tags:
Comment:
revert r111028 (attempt to fix bug 34254)

That patch was obviously wrong, it disabled compression for any
requests *blushes* :-]
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -388,12 +388,6 @@
389389 $wgCanonicalServer = wfExpandUrl( $wgServer, PROTO_HTTP );
390390 }
391391
392 -if ( $wgUseFileCache && $wgUseGzip ) {
393 - // Bypass any previous output handler to avoid double
394 - // compression (bug 34254)
395 - wfResetOutputBuffers();
396 -}
397 -
398392 wfProfileIn( $fname . '-misc1' );
399393
400394 # Raise the memory limit if it's too low
Index: trunk/phase3/RELEASE-NOTES-1.20
@@ -21,8 +21,6 @@
2222 * (bug 30245) Use the correct way to construct a log page title.
2323 * (bug 34237) Regenerate an empty user_token and save to the database
2424 when we try to set the user's cookies for login.
25 -* (bug 34254) Using a gzipped file cache ($wgUseGzip and $wgUseFileCache)
26 - compressed the output twice resulting in garbage output (since 1.18)
2725 * (bug 32210) New edit emails for watched pages always provide a link to the
2826 edit which triggered the mail.
2927 * (bug 12021) Added user talk link on Special:Listusers

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111028(bug 34254) fix gzipped file cache double compressing output...hashar11:02, 9 February 2012

Status & tagging log