r111231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111230‎ | r111231 | r111232 >
Date:12:17, 11 February 2012
Author:siebrand
Status:resolved (Comments)
Tags:backcompat 
Comment:
* Remove last remaining traces of wfLoadExtensionMessages().
* Add missing action message and remove unused global in UploadLocal.
* Some whitespace updates in Maps.
Modified paths:
  • /trunk/extensions/CreditTab/CreditTab.php (modified) (history)
  • /trunk/extensions/EmbedVideo/EmbedVideo.hooks.php (modified) (history)
  • /trunk/extensions/Favorites/SpecialFavoritelist.php (modified) (history)
  • /trunk/extensions/Maps/Maps.hooks.php (modified) (history)
  • /trunk/extensions/MassEditRegex/MassEditRegex.class.php (modified) (history)
  • /trunk/extensions/MediaWikiAuth/MediaWikiAuth.php (modified) (history)
  • /trunk/extensions/ReplaceText/ReplaceText.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/includes/SD_Utils.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_CheckboxInput.php (modified) (history)
  • /trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/storage/SMW_SQLStore2_QueriesNM.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/storage/SMW_SQLStore2_QueriesNM.smw15.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/SemanticProjectManagement.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/includes/SPM_SpecialPage.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/includes/SPM_WBS.php (modified) (history)
  • /trunk/extensions/SemanticWebBrowser/includes/datavalues/SWBResolvableUriValue.php (modified) (history)
  • /trunk/extensions/SemanticWebBrowser/specials/SearchTriple/SWB_SpecialBrowseWiki.php (modified) (history)
  • /trunk/extensions/UploadLocal/UploadLocal.i18n.php (modified) (history)
  • /trunk/extensions/UploadLocal/UploadLocal_body.php (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/PageQueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -3567,16 +3567,6 @@
35683568 }
35693569
35703570 /**
3571 - * Load an extension messages file
3572 - *
3573 - * @deprecated since 1.16, warnings in 1.18, remove in 1.20
3574 - * @codeCoverageIgnore
3575 - */
3576 -function wfLoadExtensionMessages() {
3577 - wfDeprecated( __FUNCTION__, '1.16' );
3578 -}
3579 -
3580 -/**
35813571 * Get a platform-independent path to the null file, e.g. /dev/null
35823572 *
35833573 * @return string
Index: trunk/phase3/includes/PageQueryPage.php
——@@ -6,7 +6,6 @@
77 * @ingroup SpecialPage
88 */
99 abstract class PageQueryPage extends QueryPage {
10 -
1110 /**
1211 * Format the result as a simple link to the page
1312 *
——@@ -16,11 +15,14 @@
1716 */
1817 public function formatResult( $skin, $row ) {
1918 global $wgContLang;
 19+
2020 $title = Title::makeTitleSafe( $row->namespace, $row->title );
2121 $text = $row->title;
 22+
2223 if ( $title instanceof Title ) {
2324 $text = $wgContLang->convert( $title->getPrefixedText() );
2425 }
 26+
2527 return Linker::linkKnown( $title, htmlspecialchars( $text ) );
2628 }
2729 }
Index: trunk/phase3/RELEASE-NOTES-1.20
——@@ -15,6 +15,7 @@
1616 === New features in 1.20 ===
1717 * Added TitleIsKnown hook which gets called when determining if a page exists.
1818 * (bug 32341) Add upload by URL domain limitation.
 19+* wfLoadExtensionMessages() was removed. Deprecated in 1.16, removed in 1.20.
1920
2021 === Bug fixes in 1.20 ===
2122 * (bug 30245) Use the correct way to construct a log page title.
Index: trunk/extensions/MassEditRegex/MassEditRegex.class.php
——@@ -60,8 +60,6 @@
6161 return;
6262 }
6363
64 - wfLoadExtensionMessages('MassEditRegex');
65 -
6664 $this->outputHeader();
6765
6866 $strPageList = $wgRequest->getText( 'wpPageList', 'Sandbox' );
Index: trunk/extensions/Maps/Maps.hooks.php
——@@ -2,20 +2,20 @@
33
44 /**
55 * Static class for hooks handled by the Maps extension.
6 - *
 6+ *
77 * @since 0.7
8 - *
 8+ *
99 * @file Maps.hooks.php
1010 * @ingroup Maps
11 - *
 11+ *
1212 * @licence GNU GPL v3
1313 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1414 */
1515 final class MapsHooks {
16 -
 16+
1717 /**
1818 * Adds a link to Admin Links page.
19 - *
 19+ *
2020 * @since 0.7
2121 *
2222 * @param ALTree $admin_links_tree
——@@ -23,36 +23,36 @@
2424 * @return true
2525 */
2626 public static function addToAdminLinks( ALTree &$admin_links_tree ) {
27 - $displaying_data_section = $admin_links_tree->getSection( wfMsg( 'smw_adminlinks_displayingdata' ) );
28 -
29 - // Escape if SMW hasn't added links.
30 - if ( is_null( $displaying_data_section ) ) return true;
31 - $smw_docu_row = $displaying_data_section->getRow( 'smw' );
32 -
33 - $maps_docu_label = wfMsg( 'adminlinks_documentation', 'Maps' );
34 - $smw_docu_row->addItem( AlItem::newFromExternalLink( 'http://mapping.referata.com/wiki/Maps', $maps_docu_label ) );
35 -
36 - return true;
 27+ $displaying_data_section = $admin_links_tree->getSection( wfMsg( 'smw_adminlinks_displayingdata' ) );
 28+
 29+ // Escape if SMW hasn't added links.
 30+ if ( is_null( $displaying_data_section ) ) return true;
 31+ $smw_docu_row = $displaying_data_section->getRow( 'smw' );
 32+
 33+ $maps_docu_label = wfMsg( 'adminlinks_documentation', 'Maps' );
 34+ $smw_docu_row->addItem( AlItem::newFromExternalLink( 'http://mapping.referata.com/wiki/Maps', $maps_docu_label ) );
 35+
 36+ return true;
3737 }
38 -
 38+
3939 /**
4040 * Hook to add PHPUnit test cases.
41 - *
 41+ *
4242 * @since 0.7
43 - *
 43+ *
4444 * @param array $files
4545 *
4646 * @return true
4747 */
4848 public static function registerUnitTests( array &$files ) {
4949 $testDir = dirname( __FILE__ ) . '/test/';
50 -
 50+
5151 $files[] = $testDir . 'MapsCoordinateParserTest.php';
5252 $files[] = $testDir . 'MapsDistanceParserTest.php';
53 -
 53+
5454 return true;
5555 }
56 -
 56+
5757 /**
5858 * Intercept pages in the Layer namespace to handle them correctly.
5959 *
——@@ -65,10 +65,10 @@
6666 if ( $title->getNamespace() == Maps_NS_LAYER ) {
6767 $article = new MapsLayerPage( $title );
6868 }
69 -
 69+
7070 return true;
7171 }
72 -
 72+
7373 /**
7474 * Adds global JavaScript variables.
7575 *
——@@ -80,14 +80,14 @@
8181 */
8282 public static function onMakeGlobalVariablesScript( array &$vars ) {
8383 global $egMapsGlobalJSVars;
84 -
 84+
8585 $vars['egMapsDebugJS'] = $GLOBALS['egMapsDebugJS'];
86 -
 86+
8787 $vars += $egMapsGlobalJSVars;
88 -
 88+
8989 return true;
9090 }
91 -
 91+
9292 /**
9393 * @since 0.7
9494 *
——@@ -100,4 +100,4 @@
101101 $list[Maps_NS_LAYER_TALK] = 'Layer_talk';
102102 return true;
103103 }
104 -}
 104+}
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_CheckboxInput.php
——@@ -43,12 +43,7 @@
4444 // Default to false - no need to check if it matches
4545 // a 'false' word.
4646 $vlc = strtolower( trim( $cur_value ) );
47 - // Manually load SMW's message values, if they weren't
48 - // loaded before.
49 - global $wgVersion;
50 - if ( version_compare( $wgVersion, '1.16', '<' ) ) {
51 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
52 - }
 47+
5348 if ( in_array( $vlc, explode( ',', wfMsgForContent( 'smw_true_words' ) ), true ) ) {
5449 $checked_str = ' checked="checked"';
5550 } else {
Index: trunk/extensions/SemanticProjectManagement/includes/SPM_WBS.php
——@@ -60,12 +60,9 @@
6161 }
6262
6363 public function getName() {
64 - wfLoadExtensionMessages('SemanticProjectManagement');
6564 return wfMsg('spm_printername_wbs');
6665 }
6766
68 -
69 -
7067 /**
7168 * This method renders the result set provided by SMW according to the printer
7269 *
——@@ -181,7 +178,6 @@
182179 if ($this->getSearchLabel($outputmode)) {
183180 $label = $this->getSearchLabel($outputmode);
184181 } else {
185 - wfLoadExtensionMessages('SemanticProjectManagement');
186182 $label = wfMsgForContent('spm_wbs_link');
187183 }
188184 $link = $res->getQueryLink($label);
Index: trunk/extensions/SemanticProjectManagement/includes/SPM_SpecialPage.php
——@@ -34,7 +34,6 @@
3535 */
3636 function __construct() {
3737 parent::__construct( 'SemanticProjectManagement' );
38 - wfLoadExtensionMessages( 'SemanticProjectManagement' );
3938 }
4039 //main class
4140 function execute( $par ){
Index: trunk/extensions/SemanticProjectManagement/SemanticProjectManagement.php
——@@ -107,7 +107,6 @@
108108 if ( is_null( $displaying_data_section ) )
109109 return true;
110110 $smw_docu_row = $displaying_data_section->getRow( 'smw' );
111 - wfLoadExtensionMessages( 'SemanticProjectManagement' );
112111 $srf_docu_label = wfMsg( 'adminlinks_documentation', wfMsg( 'spm-name' ) );
113112 $smw_docu_row->addItem( AlItem::newFromExternalLink( "http://www.mediawiki.org/wiki/Extension:Semantic_Project_Management", $spm_docu_label ) );
114113 return true;
Index: trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php
——@@ -478,7 +478,7 @@
479479 */
480480 protected function getSubqueryDescription( &$setNS, &$label ) {
481481 global $smwgQPrintoutLimit;
482 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
 482+
483483 $conjunction = NULL; // used for the current inner conjunction
484484 $disjuncts = array(); // (disjunctive) array of subquery conjunctions
485485 $printrequests = array(); // the printrequests found for this query level
——@@ -696,7 +696,7 @@
697697 // modified by ning ,add $relatedArticles
698698 protected function getPropertyDescription( $propertyname, &$setNS, &$label, &$relatedArticles ) {
699699 global $smwgSMWBetaCompatible; // support for old * printouts of beta
700 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
 700+
701701 $this->readChunk(); // consume separator ":=" or "::"
702702 // first process property chain syntax (e.g. "property1.property2::value"):
703703 if ( $propertyname { 0 } == ' ' ) { // escape
——@@ -916,7 +916,6 @@
917917 */
918918 // modified by ning ,add $relatedArticles
919919 protected function getArticleDescription( $firstchunk, &$setNS, &$label, &$relatedArticles ) {
920 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
921920 $chunk = $firstchunk;
922921 $result = NULL;
923922 $continue = true;
——@@ -960,7 +959,6 @@
961960 }
962961
963962 protected function finishLinkDescription( $chunk, $hasNamespaces, $result, &$setNS, &$label ) {
964 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
965963 if ( $result === NULL ) { // no useful information or concrete error found
966964 $this->m_errors[] = wfMsgForContent( 'smw_badqueryatom' );
967965 } elseif ( !$hasNamespaces && $setNS && ( $this->m_defaultns !== NULL ) ) {
——@@ -1072,7 +1070,6 @@
10731071 * also be changed (if it was non-NULL).
10741072 */
10751073 protected function addDescription( $curdesc, $newdesc, $conjunction = true ) {
1076 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
10771074 $notallowedmessage = 'smw_noqueryfeature';
10781075 if ( $newdesc instanceof SMWSomeProperty ) {
10791076 $allowed = $this->m_queryfeatures & SMW_PROPERTY_QUERY;
Index: trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.php
——@@ -478,7 +478,7 @@
479479 */
480480 protected function getSubqueryDescription( &$setNS, &$label ) {
481481 global $smwgQPrintoutLimit;
482 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
 482+
483483 $conjunction = NULL; // used for the current inner conjunction
484484 $disjuncts = array(); // (disjunctive) array of subquery conjunctions
485485 $printrequests = array(); // the printrequests found for this query level
——@@ -696,7 +696,7 @@
697697 // modified by ning ,add $relatedArticles
698698 protected function getPropertyDescription( $propertyname, &$setNS, &$label, &$relatedArticles ) {
699699 global $smwgSMWBetaCompatible; // support for old * printouts of beta
700 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
 700+
701701 $this->readChunk(); // consume separator ":=" or "::"
702702 // first process property chain syntax (e.g. "property1.property2::value"):
703703 if ( $propertyname { 0 } == ' ' ) { // escape
——@@ -916,7 +916,7 @@
917917 */
918918 // modified by ning ,add $relatedArticles
919919 protected function getArticleDescription( $firstchunk, &$setNS, &$label, &$relatedArticles ) {
920 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
 920+
921921 $chunk = $firstchunk;
922922 $result = NULL;
923923 $continue = true;
——@@ -960,7 +960,6 @@
961961 }
962962
963963 protected function finishLinkDescription( $chunk, $hasNamespaces, $result, &$setNS, &$label ) {
964 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
965964 if ( $result === NULL ) { // no useful information or concrete error found
966965 $this->m_errors[] = wfMsgForContent( 'smw_badqueryatom' );
967966 } elseif ( !$hasNamespaces && $setNS && ( $this->m_defaultns !== NULL ) ) {
——@@ -1072,7 +1071,6 @@
10731072 * also be changed (if it was non-NULL).
10741073 */
10751074 protected function addDescription( $curdesc, $newdesc, $conjunction = true ) {
1076 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
10771075 $notallowedmessage = 'smw_noqueryfeature';
10781076 if ( $newdesc instanceof SMWSomeProperty ) {
10791077 $allowed = $this->m_queryfeatures & SMW_PROPERTY_QUERY;
Index: trunk/extensions/SemanticNotifyMe/includes/storage/SMW_SQLStore2_QueriesNM.php
——@@ -282,7 +282,6 @@
283283 $qid = $this->compileQueries( $desc );
284284 $query = $this->m_queries[$qid];
285285 } else {
286 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
287286 $this->m_errors[] = wfMsg( 'smw_concept_cache_miss', $description->getConcept()->getText() );
288287 }
289288 } // else: no cache, no description (this may happen); treat like empty concept
Index: trunk/extensions/SemanticNotifyMe/includes/storage/SMW_SQLStore2_QueriesNM.smw15.php
——@@ -389,11 +389,9 @@
390390 if ( $qid != -1 ) {
391391 $query = $this->m_queries[$qid];
392392 } else { // somehow the concept query is no longer valid; maybe some syntax changed (upgrade) or global settings were modified since storing it
393 - smwfLoadExtensionMessages( 'SemanticMediaWiki' );
394393 $this->m_errors[] = wfMsg( 'smw_emptysubquery' ); // not quite the right message, but this case is very rare; let us not make detailed messages for this
395394 }
396395 } else {
397 - smwfLoadExtensionMessages( 'SemanticMediaWiki' );
398396 $this->m_errors[] = wfMsg( 'smw_concept_cache_miss', $description->getConcept()->getText() );
399397 }
400398 } // else: no cache, no description (this may happen); treat like empty concept
Index: trunk/extensions/UploadLocal/UploadLocal_body.php
——@@ -3,12 +3,10 @@
44 class UploadLocal extends SpecialPage {
55 function __construct() {
66 parent::__construct( 'UploadLocal', 'uploadlocal' );
7 - wfLoadExtensionMessages( 'UploadLocal' );
87 }
98
109 function execute( $par ) {
11 - global $wgRequest, $wgUploadLocalDirectory, $wgMessageCache;
12 - wfLoadExtensionMessages( 'UploadLocal' );
 10+ global $wgRequest, $wgUploadLocalDirectory;
1311
1412 $prefix = 'extensions/UploadLocal/';
1513 require($prefix . 'UploadLocalDirectory.php');
Index: trunk/extensions/UploadLocal/UploadLocal.i18n.php
——@@ -46,5 +46,6 @@
4747 'uploadlocal_error_unknown' => 'An unknown error occurred.',
4848
4949 'right-uploadlocal' => 'Upload files from the local machine'
 50+ 'action-uploadlocal' => 'upload files from the local machine'
5051 );
5152
Index: trunk/extensions/CreditTab/CreditTab.php
——@@ -15,7 +15,7 @@
1616 'path' => __FILE__,
1717 'name' => 'CreditTab',
1818 'author' => '[http://www.dasch-tour.de DaSch]',
19 - 'version' => '1.2.2',
 19+ 'version' => '1.3.0',
2020 'descriptionmsg' => 'credits-desc',
2121 'url' => 'https://www.mediawiki.org/wiki/Extension:CreditTab',
2222 );
——@@ -54,7 +54,7 @@
5555 } else {
5656 $title = $obj->mTitle;
5757 }
58 - wfLoadExtensionMessages('CreditTab');
 58+
5959 $ctNamespace = $title->getNamespace();
6060 $ctInsert=false;
6161 if ( count( $wgCreditTabNamespaces ) > 0 ) {
Index: trunk/extensions/SemanticDrilldown/includes/SD_Utils.php
——@@ -340,9 +340,6 @@
341341 }
342342
343343 static function booleanToString( $bool_value ) {
344 - if ( function_exists( 'wfLoadExtensionMessages' ) ) {
345 - wfLoadExtensionMessages( 'SemanticMediaWiki' );
346 - }
347344 $words_field_name = ( $bool_value == true ) ? 'smw_true_words' : 'smw_false_words';
348345 $words_array = explode( ',', wfMsgForContent( $words_field_name ) );
349346 // go with the value in the array that tends to be "yes" or
Index: trunk/extensions/MediaWikiAuth/MediaWikiAuth.php
——@@ -134,7 +134,6 @@
135135 $results = unserialize( $this->snoopy->results );
136136 wfDebugLog( 'MediaWikiAuth', 'Login result:' . print_r( $results, true ) );
137137
138 - wfLoadExtensionMessages( 'MediaWikiAuth' );
139138 $errormsg = wfMsg( 'mwa-error-unknown' );
140139 if ( isset( $results['login'] ) ) {
141140 $login = $results['login'];
Index: trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.php
——@@ -96,10 +96,5 @@
9797 $sfgFormPrinter->registerInputType( 'SFIMenuSelect' );
9898 $sfgFormPrinter->registerInputType( 'SFIRegExp' );
9999
100 - // This function has been deprecated in 1.16, but needed for earlier versions.
101 - if ( version_compare( $wgVersion, '1.16', '<' ) ) {
102 - wfLoadExtensionMessages( 'SemanticFormsInputs' );
103 - }
104 -
105100 return true;
106101 }
Index: trunk/extensions/Favorites/SpecialFavoritelist.php
——@@ -13,7 +13,6 @@
1414 class SpecialFavoritelist extends SpecialPage {
1515 function __construct() {
1616 parent::__construct( 'Favoritelist' );
17 - wfLoadExtensionMessages('Favoritelist');
1817 }
1918
2019 function execute( $par ) {
Index: trunk/extensions/EmbedVideo/EmbedVideo.hooks.php
——@@ -57,8 +57,6 @@
5858 # Initialize things once
5959 if (!EmbedVideo::$initialized) {
6060 EmbedVideo::VerifyWidthMinAndMax();
61 - # Add system messages
62 - wfLoadExtensionMessages('embedvideo');
6361 $parser->disableCache();
6462 EmbedVideo::$initialized = true;
6563 }
Index: trunk/extensions/SemanticWebBrowser/specials/SearchTriple/SWB_SpecialBrowseWiki.php
——@@ -52,7 +52,7 @@
5353 public function __construct() {
5454 global $smwgBrowseShowAll;
5555 parent::__construct( 'BrowseWiki', '', true, false, 'default', true );
56 - smwfLoadExtensionMessages( 'SemanticMediaWiki' );
 56+
5757 if ( $smwgBrowseShowAll ) {
5858 SWBSpecialBrowseWiki::$incomingvaluescount = 21;
5959 SWBSpecialBrowseWiki::$incomingpropertiescount = - 1;
Index: trunk/extensions/SemanticWebBrowser/includes/datavalues/SWBResolvableUriValue.php
——@@ -28,7 +28,6 @@
2929 protected function parseUserValue( $value ) {
3030 // echo "parseUserValue";
3131
32 - smwfLoadExtensionMessages( 'SemanticMediaWiki' );
3332 $value = trim( $value );
3433 $this->m_wikitext = $value;
3534 if ( $this->m_caption === false ) {
Index: trunk/extensions/ReplaceText/ReplaceText.php
——@@ -48,11 +48,14 @@
4949 // This function should really go into a "ReplaceText_body.php" file.
5050 function rtAddToAdminLinks( &$admin_links_tree ) {
5151 $general_section = $admin_links_tree->getSection( wfMsg( 'adminlinks_general' ) );
52 - $extensions_row = $general_section->getRow( 'extensions' );
 52+ $extensions_row = $general_section->getRow( 'extensions' );
 53+
5354 if ( is_null( $extensions_row ) ) {
5455 $extensions_row = new ALRow( 'extensions' );
5556 $general_section->addRow( $extensions_row );
5657 }
 58+
5759 $extensions_row->addItem( ALItem::newFromSpecialPage( 'ReplaceText' ) );
 60+
5861 return true;
5962 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r111323revert core part of r111231...hashar19:40, 12 February 2012
r112386Fix syntax error and trim some whitespacesialex12:19, 25 February 2012

Comments

#Comment by RobLa-WMF (talk | contribs)   17:27, 11 February 2012

Per our frequent conversations on wikitech-l, we shouldn't break backwards compatibility unless we have to. This function is doing no harm (it's doing nothing). The Semantic MediaWiki folks have explicitly stated their desire to support older versions of MediaWiki, yet you even broke their code that would still work *with* removing the function: 

-			if ( version_compare( $wgVersion, '1.16', '<' ) ) {
-				wfLoadExtensionMessages( 'SemanticMediaWiki' );
-			}

...and you removed smwfLoadExtensionMessages() as well.

That's just rude. Please revert.

#Comment by Siebrand (talk | contribs)   08:13, 12 February 2012

Hey Rob. Thanks for taking the time to so carefully review the changes I made in this revision. I appreciate it a lot. tl;dr: I think you underestimate the research I did before making these changes. I elaborate below.

Reading the README file of SemanticMediaWiki, an extension required by every and all Semantic* extensions, I see that the requirement was MediaWiki 1.16 or later. Any and all checks for lower versions of MediaWiki no longer make sense. smwfLoadExtensionMessages() is a no-op. Calling it does not serve any purpose. It is being kept in SemanticMediaWiki to avoid complete breakage (fatals), and is scheduled to be removed there in SemanticMediaWiki 1.9.

GlobalFunctions.php indicated that wfLoadExtensionMessages was marked deprecated in MediaWiki 1.16 some 18 months ago, it has been throwing deprecation warnings since MediaWiki 1.18 and is scheduled to be removed in MediaWiki 1.20. Now that MediaWiki has reached 1.20 alpha state, it is exactly that time to remove it. I don't think the changes made in this revision were rude. No breakage whatsoever was introduced for any MediaWiki version at 1.16 or above.

Because of the above, I will not comply to your request to revert. Would you still feel that these changes need to be reverted because they were "just rude" and break backwards compatibility, then feel free to revert yourself, our delegate it to someone else.

#Comment by Hashar (talk | contribs)   19:41, 12 February 2012

With r111323 I have reverted your change to core. The extension part is fine though since the function has been doing nothing since 1.16 =)

We could remove the extension later on.

#Comment by Hashar (talk | contribs)   19:41, 12 February 2012

We could remove the wfLoadExtensionMessages function later on.

Status & tagging log