r111144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111143‎ | r111144 | r111145 >
Date:01:35, 10 February 2012
Author:aaron
Status:ok
Tags:
Comment:
r111076: url decode the 'rel404' path...*ahem*. Archived files and files with special chars are otherwise broken.
Modified paths:
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/thumb.php
@@ -178,7 +178,7 @@
179179 // Check that the zone relative path matches up so squid caches won't pick
180180 // up thumbs that would not be purged on source file deletion (bug 34231).
181181 if ( isset( $params['rel404'] ) // thumbnail was handled via 404
182 - && $params['rel404'] !== $img->getThumbRel( $thumbName ) )
 182+ && urldecode( $params['rel404'] ) !== $img->getThumbRel( $thumbName ) )
183183 {
184184 wfThumbError( 404, 'The source file for the specified thumbnail does not exist.' );
185185 wfProfileOut( __METHOD__ );

Follow-up revisions

RevisionCommit summaryAuthorDate
r111175REL1_19: MFT r111029, r111034, r111067, r111076, r111085, r111128, r111144reedy18:37, 10 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111076(bug 34231) - 'Make thumb.php error or redirect for urls with bogus paths but...aaron19:45, 9 February 2012

Status & tagging log