r111128 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111127‎ | r111128 | r111129 >
Date:23:56, 9 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r106752: let TempFSFile deletions happen when the object goes out of scope, as you would expect with this RAII pattern, rather than leaving it until shutdown. PHP has lots of bugs in its shutdown process so doing the file delete at scope destruction means it's more likely to happen.
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/TempFSFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/TempFSFile.php
@@ -41,9 +41,6 @@
4242 }
4343 }
4444 $tmpFile = new self( $path );
45 - if ( php_sapi_name() != 'cli' ) {
46 - self::$instances[] = $tmpFile; // defer purge till shutdown
47 - }
4845 return $tmpFile;
4946 }
5047

Follow-up revisions

RevisionCommit summaryAuthorDate
r111175REL1_19: MFT r111029, r111034, r111067, r111076, r111085, r111128, r111144reedy18:37, 10 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106752Merged FileBackend branch. Manually avoiding merging the many prop-only chang...aaron03:52, 20 December 2011

Status & tagging log