r110982 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110981‎ | r110982 | r110983 >
Date:23:25, 8 February 2012
Author:aaron
Status:ok (Comments)
Tags:
Comment:
r110979: removed implode() call and format the message as plaintext, as any HTML will be escaped anyway for such exceptions.
Modified paths:
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadStash.php
——@@ -215,7 +215,7 @@
216216 }
217217 }
218218 // at this point, $error should contain the single "most important" error, plus any parameters.
219 - throw new UploadStashFileException( "Error storing file in '$path': " . implode( '; ', wfMessage( $error ) ) );
 219+ throw new UploadStashFileException( "Error storing file in '$path': " . wfMessage( $error )->text() );
220220 }
221221 $stashPath = $storeStatus->value;
222222

Sign-offs

UserFlagDate
Nikerabbitinspected07:20, 9 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110979Properly expand the "error storing file" message. Fixes bug 33846raindrift23:09, 8 February 2012

Comments

#Comment by Raindrift (talk | contribs)   01:05, 9 February 2012

Thank you (derp)

Status & tagging log