r110981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110980‎ | r110981 | r110982 >
Date:23:17, 8 February 2012
Author:werdna
Status:ok
Tags:
Comment:
ArticleCreationWorkflow: Swap some IDs around and genericise the interstitial action code
Modified paths:
  • /trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.php (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.user/ext.articleCreation.user.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.user/ext.articleCreation.user.js
@@ -103,8 +103,8 @@
104104
105105 ac.panel.find('.mw-ac-tip').localize();
106106
107 - ac.panel.find('.ac-article-create')
108 - .parent().find('.ac-action-button')
 107+ ac.panel.find('.mw-ac-interstitial')
 108+ .find('.ac-action-button')
109109 .click( function(e) {
110110 e.preventDefault();
111111 ac.executeAction($(this).data('ac-action'));
@@ -123,7 +123,7 @@
124124 },
125125
126126 executeAction : function( action ) {
127 - if ( $('#mw-ac-create-dismiss').is(':checked') ) {
 127+ if ( $('#mw-ac-dismiss-interstitial').is(':checked') ) {
128128 ac.disableInterstitial( action );
129129 }
130130
Index: trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.php
@@ -142,8 +142,8 @@
143143 </div>
144144 <input
145145 type="checkbox"
146 - id="mw-ac-create-dismiss" />
147 - <label for="mw-ac-create-dismiss">
 146+ id="mw-ac-dismiss-interstitial" />
 147+ <label for="mw-ac-dismiss-interstitial">
148148 <html:msg key="ac-create-dismiss" />
149149 </label>
150150 <div style="clear: both"></div>

Status & tagging log