r110942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110941‎ | r110942 | r110943 >
Date:16:58, 8 February 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
fix doc grouping for actions
Modified paths:
  • /trunk/phase3/includes/Action.php (modified) (history)
  • /trunk/phase3/includes/actions/RevertAction.php (modified) (history)
  • /trunk/phase3/includes/actions/RollbackAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/RevertAction.php
@@ -17,7 +17,7 @@
1818 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
1919 *
2020 * @file
21 - * @ingroup Action
 21+ * @ingroup Actions
2222 * @ingroup Media
2323 * @author Alexandre Emsenhuber
2424 * @author Rob Church <robchur@gmail.com>
@@ -26,7 +26,7 @@
2727 /**
2828 * Dummy class for pages not in NS_FILE
2929 *
30 - * @ingroup Action
 30+ * @ingroup Actions
3131 */
3232 class RevertAction extends Action {
3333
@@ -44,7 +44,7 @@
4545 /**
4646 * Class for pages in NS_FILE
4747 *
48 - * @ingroup Action
 48+ * @ingroup Actions
4949 */
5050 class RevertFileAction extends FormAction {
5151 protected $oldFile;
Index: trunk/phase3/includes/actions/RollbackAction.php
@@ -17,13 +17,13 @@
1818 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
1919 *
2020 * @file
21 - * @ingroup Action
 21+ * @ingroup Actions
2222 */
2323
2424 /**
2525 * User interface for the rollback action
2626 *
27 - * @ingroup Action
 27+ * @ingroup Actions
2828 */
2929 class RollbackAction extends FormlessAction {
3030
Index: trunk/phase3/includes/Action.php
@@ -1,5 +1,9 @@
22 <?php
33 /**
 4+ * @defgroup Actions Action done on pages
 5+ */
 6+
 7+/**
48 * Actions are things which can be done to pages (edit, delete, rollback, etc). They
59 * are distinct from Special Pages because an action must apply to exactly one page.
610 *

Comments

#Comment by Aaron Schulz (talk | contribs)   20:06, 8 February 2012

What was wrong with it before? Grouping by base class seemed OK.

#Comment by Hashar (talk | contribs)   10:20, 9 February 2012

We had actions in two different "Action" groups, the plural one "Actions" and the singular one "Action". Should probably have used the singular form.

Status & tagging log