r110943 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110942‎ | r110943 | r110944 >
Date:17:03, 8 February 2012
Author:hashar
Status:ok
Tags:
Comment:
Fix doc for includes/upload
Modified paths:
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromChunks.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromFile.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromStash.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromUrl.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromStash.php
@@ -2,11 +2,9 @@
33 /**
44 * Implements uploading from previously stored file.
55 *
6 - * @file
7 - * @ingroup upload
 6+ * @ingroup Upload
87 * @author Bryan Tong Minh
98 */
10 -
119 class UploadFromStash extends UploadBase {
1210 protected $mFileKey, $mVirtualTempPath, $mFileProps, $mSourceType;
1311
Index: trunk/phase3/includes/upload/UploadFromUrl.php
@@ -2,8 +2,7 @@
33 /**
44 * Implements uploading from a HTTP resource.
55 *
6 - * @file
7 - * @ingroup upload
 6+ * @ingroup Upload
87 * @author Bryan Tong Minh
98 * @author Michael Dale
109 */
Index: trunk/phase3/includes/upload/UploadBase.php
@@ -1,7 +1,10 @@
22 <?php
33 /**
4 - * @file
5 - * @ingroup upload
 4+ * @defgroup Upload
 5+ */
 6+
 7+/**
 8+ * @ingroup Upload
69 *
710 * UploadBase and subclasses are the backend of MediaWiki's file uploads.
811 * The frontends are formed by ApiUpload and SpecialUpload.
@@ -12,7 +15,6 @@
1316 * @author Bryan Tong Minh
1417 * @author Michael Dale
1518 */
16 -
1719 abstract class UploadBase {
1820 protected $mTempPath;
1921 protected $mDesiredDestName, $mDestName, $mRemoveTempFile, $mSourceType;
Index: trunk/phase3/includes/upload/UploadFromChunks.php
@@ -2,11 +2,9 @@
33 /**
44 * Implements uploading from chunks
55 *
6 - * @file
7 - * @ingroup upload
 6+ * @ingroup Upload
87 * @author Michael Dale
98 */
10 -
119 class UploadFromChunks extends UploadFromFile {
1210 protected $mOffset, $mChunkIndex, $mFileKey, $mVirtualTempPath;
1311
Index: trunk/phase3/includes/upload/UploadStash.php
@@ -16,6 +16,8 @@
1717 * UploadStash represents the entire stash of temporary files.
1818 * UploadStashFile is a filestore for the actual physical disk files.
1919 * UploadFromStash extends UploadBase, and represents a single stashed file as it is moved from the stash to the regular file repository
 20+ *
 21+ * @ingroup Upload
2022 */
2123 class UploadStash {
2224
Index: trunk/phase3/includes/upload/UploadFromFile.php
@@ -2,11 +2,9 @@
33 /**
44 * Implements regular file uploads
55 *
6 - * @file
7 - * @ingroup upload
 6+ * @ingroup Upload
87 * @author Bryan Tong Minh
98 */
10 -
119 class UploadFromFile extends UploadBase {
1210
1311 /**

Status & tagging log