r110805 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r110804‎ \| r110805 \| r110806 >
Date:	23:50, 6 February 2012
Author:	tparscal
Status:	deferred
Tags:	nodeploy, visualeditor
Comment:	Migrated es.* to new ve.* namespace which is more structured, and will make it easier to keep data model, edit surface, user interface and content editable work separated cleanly
Modified paths:	/trunk/extensions/VisualEditor/VisualEditor.php (modified) (history) /trunk/extensions/VisualEditor/demo/index.php (modified) (history) /trunk/extensions/VisualEditor/modules/es (deleted) (history) /trunk/extensions/VisualEditor/modules/sandbox/sandbox.js (modified) (history) /trunk/extensions/VisualEditor/modules/ve (added) (history) /trunk/extensions/VisualEditor/modules/ve/ce (added) (history) /trunk/extensions/VisualEditor/modules/ve/ce/ve.ce.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.DocumentNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.HeadingNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.ListItemNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.ListNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.ParagraphNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.PreNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.TableCellNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.TableNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/nodes/ve.dm.TableRowNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/serializers (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/serializers/ve.dm.AnnotationSerializer.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/serializers/ve.dm.HtmlSerializer.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/serializers/ve.dm.JsonSerializer.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/serializers/ve.dm.WikitextSerializer.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.BranchNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.LeafNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.Node.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.Surface.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.Transaction.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.TransactionProcessor.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/dm/ve.dm.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.DocumentNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.HeadingNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.ListItemNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.ListNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.ParagraphNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.PreNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.TableCellNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.TableNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/nodes/ve.es.TableRowNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles/images (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles/images/bullet-icon.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles/ve.es.Content.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles/ve.es.Document.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/styles/ve.es.Surface.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.BranchNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.Content.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.LeafNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.Node.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.Surface.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/es/ve.es.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/inspectors (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/inspectors/ve.ui.LinkInspector.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/accept.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/arrow-down.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/arrow-up.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/bold.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/bullet.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/clear.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/close.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/data.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/fade-down.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/fade-up.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/help.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/history.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/html.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/icons.psd (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/indent.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/italic.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/json.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/link.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/number.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/outdent.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/redo.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/render.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/toolbar-shadow.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/undo.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/images/wikitext.png (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/ve.ui.Context.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/ve.ui.Inspector.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/ve.ui.Menu.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/styles/ve.ui.Toolbar.css (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.AnnotationButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.ButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.ClearButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.DropdownTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.FormatDropdownTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.HistoryButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.IndentationButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/tools/ve.ui.ListButtonTool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.Context.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.Inspector.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.Menu.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.Tool.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.Toolbar.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ui/ve.ui.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.BranchNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.EventEmitter.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.LeafNode.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.Node.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.Position.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.Range.js (added) (history) /trunk/extensions/VisualEditor/modules/ve/ve.js (added) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r110806	Fixed image file links from sandbox.css to images supplied by es and ui packages	tparscal	23:55, 6 February 2012
r110809	Updated unit tests in response to structural changes in r110805	tparscal	00:12, 7 February 2012
r110814	Fixed backspace - another issue related the r110805 (or as we are now calling...	tparscal	01:11, 7 February 2012

Status & tagging log

07:19, 7 February 2012 Aaron Schulz (talk | contribs) changed the status of r110805 [removed: new added: deferred]
00:48, 7 February 2012 RobLa-WMF (talk | contribs) changed the tags for r110805 [added: visualeditor,nodeploy]