r110814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110813‎ | r110814 | r110815 >
Date:01:11, 7 February 2012
Author:tparscal
Status:deferred
Tags:nodeploy, visualeditor 
Comment:
Fixed backspace - another issue related the r110805 (or as we are now calling it, "The Great Code Migration of 2012")
Modified paths:
  • /trunk/extensions/VisualEditor/modules/ve/es/ve.es.Node.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/ve/es/ve.es.Node.js
——@@ -91,10 +91,10 @@
9292
9393 ve.Node.traverseUpstream( node, function( node ) {
9494 var elementType = node.model.getElementType();
95 - if ( splitableNode != null && ve.es.Node.splitRules[ elementType ].children === true ) {
 95+ if ( splitableNode != null && ve.es.DocumentNode.splitRules[ elementType ].children === true ) {
9696 return false;
9797 }
98 - splitableNode = ve.es.Node.splitRules[ elementType ].self ? node : null
 98+ splitableNode = ve.es.DocumentNode.splitRules[ elementType ].self ? node : null
9999 } );
100100 return splitableNode;
101101 };

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110805Migrated es.* to new ve.* namespace which is more structured, and will make i...tparscal23:50, 6 February 2012

Status & tagging log