r110800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110799‎ | r110800 | r110801 >
Date:22:59, 6 February 2012
Author:pgehres
Status:ok
Tags:fundraising, nodeploy 
Comment:
Fixing CSS for AU, CA, and US for abbreviated state names. The default should be full-width with abbreviated as the exception
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/css/gc.cc.css (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/css/gc.css (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/AU.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/CA.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/CA.html
@@ -22,7 +22,7 @@
2323 <tr>
2424 <td colspan="2">
2525 <input class="halfwidth state" name="city" value="@city" type="text" title="%donate_interface-donor-city%" placeholder="%donate_interface-donor-city%" id="city">
26 - <select id="state" name="state" class="txt" value="@state" >
 26+ <select id="state" name="state" class="ca" value="@state" >
2727 <option value=""></option>
2828 <option value="AB">AB</option>
2929 <option value="BC">BC</option>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/AU.html
@@ -23,7 +23,7 @@
2424 <td colspan="2" style="white-space: nowrap;">
2525 <!-- TODO: get locality into translation and then use the message -->
2626 <input class="halfwidth state" name="city" value="@city" type="text" title="Suburb / Town" placeholder="Suburb / Town" id="city">
27 - <select id="state" name="state" class="txt" value="@state" >
 27+ <select id="state" name="state" class="au" value="@state" >
2828 <option value=""></option>
2929 <option value="ACT">ACT</option>
3030 <option value="NSW">NSW</option>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/css/gc.css
@@ -190,7 +190,7 @@
191191 width:84px;
192192 margin-left: 0;
193193 }
194 -select#state.us {
 194+select#state.us, select#state.au, select#state.ca {
195195 width: 50px;
196196 }
197197
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/css/gc.cc.css
@@ -190,7 +190,7 @@
191191 width:84px;
192192 margin-left: 0;
193193 }
194 -select#state.us {
 194+select#state.us, select#state.au, select#state.ca {
195195 width: 50px;
196196 }
197197

Follow-up revisions

RevisionCommit summaryAuthorDate
r110819MFT r109685, r110438, r110440, r110448, r110736, r110773, r110800, r110803khorn02:23, 7 February 2012
r110862MFT r110737, r110800khorn18:27, 7 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110737Updating forms for upcoming Africa test (forgot CSS) FU r110736pgehres08:40, 6 February 2012

Status & tagging log