r109685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109684‎ | r109685 | r109686 >
Date:18:51, 21 January 2012
Author:tstarling
Status:ok
Tags:i18nreview 
Comment:
Improved Australian localisation:
* Use "Suburb / Town" per convention instead of the technical term "locality"
* Removed "JBT" from the state list. I've honestly never seen those three letters put together before, but I assume they refer to the Jervis Bay Territory, which has an ACT postal code.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/AU.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/bt/bt-AU.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/obt/obt-bpay.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects2nd-AU.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/obt/obt-bpay.html
——@@ -55,12 +55,11 @@
5656 <div class="loc-fields">
5757 <!-- TODO: add locality to translation -->
5858 <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
59 - <span class="loc-city"><input class="txt" id="city" name="city" title="Locality" value="@city" placeholder="Locality"/></span>
 59+ <span class="loc-city"><input class="txt" id="city" name="city" title="Suburb / Town" value="@city" placeholder="Suburb / Town"/></span>
6060 <span class="loc-state">
6161 <select id="state" name="state" class="txt" value="@state" >
6262 <option value="">%donate_interface-donor-state%</option>
6363 <option value="ACT">ACT</option>
64 - <option value="JBT">JBT</option>
6564 <option value="NSW">NSW</option>
6665 <option value="NT">NT</option>
6766 <option value="QLD">QLD</option>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects2nd-AU.html
——@@ -69,12 +69,11 @@
7070 </div>
7171 <div class="loc-fields">
7272 <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
73 - <span class="loc-city"><input class="txt" id="city" name="city" title="Locality" value="@city" placeholder="Locality"/></span>
 73+ <span class="loc-city"><input class="txt" id="city" name="city" title="Suburb / Town" value="@city" placeholder="Suburb / Town"/></span>
7474 <span class="loc-state">
7575 <select id="state" name="state" class="txt" value="@state" >
7676 <option value="">%donate_interface-donor-state%</option>
7777 <option value="ACT">ACT</option>
78 - <option value="JBT">JBT</option>
7978 <option value="NSW">NSW</option>
8079 <option value="NT">NT</option>
8180 <option value="QLD">QLD</option>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/AU.html
——@@ -22,11 +22,10 @@
2323 <tr>
2424 <td colspan="2" style="white-space: nowrap;">
2525 <!-- TODO: get locality into translation and then use the message -->
26 - <input class="halfwidth state" name="city" value="@city" type="text" title="Locality" placeholder="Locality" id="city">
 26+ <input class="halfwidth state" name="city" value="@city" type="text" title="Suburb / Town" placeholder="Suburb / Town" id="city">
2727 <select id="state" name="state" class="txt" value="@state" >
2828 <option value=""></option>
2929 <option value="ACT">ACT</option>
30 - <option value="JBT">JBT</option>
3130 <option value="NSW">NSW</option>
3231 <option value="NT">NT</option>
3332 <option value="QLD">QLD</option>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/bt/bt-AU.html
——@@ -55,12 +55,11 @@
5656 <div class="loc-fields">
5757 <!-- TODO: add locality to translation -->
5858 <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
59 - <span class="loc-city"><input class="txt" id="city" name="city" title="Locality" value="@city" placeholder="Locality"/></span>
 59+ <span class="loc-city"><input class="txt" id="city" name="city" title="Suburb / Town" value="@city" placeholder="Suburb / Town"/></span>
6060 <span class="loc-state">
6161 <select id="state" name="state" class="txt" value="@state" >
6262 <option value="">%donate_interface-donor-state%</option>
6363 <option value="ACT">ACT</option>
64 - <option value="JBT">JBT</option>
6564 <option value="NSW">NSW</option>
6665 <option value="NT">NT</option>
6766 <option value="QLD">QLD</option>

Follow-up revisions

RevisionCommit summaryAuthorDate
r110819MFT r109685, r110438, r110440, r110448, r110736, r110773, r110800, r110803khorn02:23, 7 February 2012

Status & tagging log