r110619 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110618‎ | r110619 | r110620 >
Date:21:41, 2 February 2012
Author:catrope
Status:resolved
Tags:
Comment:
Followup r110542: unbreak the QUnit tests; the change wasn't broken but the test runner was. Reflect the dependency change (mw.page.startup now depends on mw.util) by moving up mw.util . It's kind of annoying that the test suite doesn't use the dependency map from Resources.php
Modified paths:
  • /trunk/phase3/tests/qunit/index.html (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/index.html
——@@ -55,15 +55,15 @@
5656
5757 <!-- MW: mediawiki.page.startup -->
5858 <script src="../../resources/jquery/jquery.client.js"></script>
 59+ <script src="../../resources/mediawiki/mediawiki.util.js"></script>
5960 <script src="../../resources/mediawiki.page/mediawiki.page.startup.js"></script>
6061
61 - <!-- MW: mediawiki.user|mediawiki.util|mediawiki.page.ready -->
 62+ <!-- MW: mediawiki.user|mediawiki.page.ready -->
6263 <script src="../../resources/jquery/jquery.cookie.js"></script>
6364 <script src="../../resources/mediawiki/mediawiki.user.js"></script>
6465
6566 <script src="../../resources/jquery/jquery.messageBox.js"></script>
6667 <script src="../../resources/jquery/jquery.mwExtension.js"></script>
67 - <script src="../../resources/mediawiki/mediawiki.util.js"></script>
6868
6969 <script src="../../resources/jquery/jquery.checkboxShiftClick.js"></script>
7070 <script src="../../resources/jquery/jquery.makeCollapsible.js"></script>

Follow-up revisions

RevisionCommit summaryAuthorDate
r111377[JSTesting] Follow-up r110619: Fix introduced race-condition...krinkle15:13, 13 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110542Enqueue mw.util.init in document-ready even handler earlier...krinkle00:47, 2 February 2012

Status & tagging log