r111377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111376‎ | r111377 | r111378 >
Date:15:13, 13 February 2012
Author:krinkle
Status:ok
Tags:
Comment:
[JSTesting] Follow-up r110619: Fix introduced race-condition
- mediawiki.util has dependencies as well, load order is important.
- This index.html is very hairy and most people should just ignore it, it predates the automated ResourceLoader-ified Special:JavaScriptTesting page, hence the manual dependency resolution here.
Modified paths:
  • /trunk/phase3/tests/qunit/index.html (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/index.html
——@@ -53,17 +53,15 @@
5454 <script src="../../resources/jquery/jquery.js"></script>
5555 <script src="../../resources/mediawiki/mediawiki.js"></script>
5656
57 - <!-- MW: mediawiki.page.startup -->
 57+ <!-- MW: mediawiki.user|mediawiki.util|mediawiki.page.startup|mediawiki.page.ready -->
5858 <script src="../../resources/jquery/jquery.client.js"></script>
59 - <script src="../../resources/mediawiki/mediawiki.util.js"></script>
60 - <script src="../../resources/mediawiki.page/mediawiki.page.startup.js"></script>
61 -
62 - <!-- MW: mediawiki.user|mediawiki.page.ready -->
6359 <script src="../../resources/jquery/jquery.cookie.js"></script>
6460 <script src="../../resources/mediawiki/mediawiki.user.js"></script>
6561
6662 <script src="../../resources/jquery/jquery.messageBox.js"></script>
6763 <script src="../../resources/jquery/jquery.mwExtension.js"></script>
 64+ <script src="../../resources/mediawiki/mediawiki.util.js"></script>
 65+ <script src="../../resources/mediawiki.page/mediawiki.page.startup.js"></script>
6866
6967 <script src="../../resources/jquery/jquery.checkboxShiftClick.js"></script>
7068 <script src="../../resources/jquery/jquery.makeCollapsible.js"></script>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110619Followup r110542: unbreak the QUnit tests; the change wasn't broken but the t...catrope21:41, 2 February 2012

Status & tagging log