r110445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110444‎ | r110445 | r110446 >
Date:22:39, 31 January 2012
Author:gregchiasson
Status:resolved (Comments)
Tags:aft 
Comment:
AFT5 - working help links.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
——@@ -108,7 +108,14 @@
109109 return;
110110 }
111111
112 - # TODO: Fix links.
 112+ $helpPage = 'Article_Feedback_Tool/Version_5/Help/Feedback_page';
 113+ if( $wgUser->isAllowed( 'aftv5-delete-feedback' ) ) {
 114+ $helpPage = 'Article_Feedback_Tool/Version_5/Help/Feedback_page_Oversighters';
 115+ } elseif( $wgUser->isAllowed( 'aftv5-hide-feedback' ) ) {
 116+ $helpPage = 'Article_Feedback_Tool/Version_5/Help/Feedback_page_Hiders';
 117+ }
 118+
 119+ $helpTitle = Title::newFromText( $helpPage, 'Wikipedia' );
113120 $out->addHTML(
114121 Html::openElement(
115122 'div',
——@@ -129,7 +136,7 @@
130137 )
131138 . ' | ' .
132139 Linker::link(
133 - $title,
 140+ $helpTitle,
134141 $this->msg( 'articlefeedbackv5-whats-this' )->escaped()
135142 )
136143 . Html::closeElement( 'div' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r110509AFT5 - Use NS_PROJECT instead of hard-coding project name. Fixes r110445gregchiasson19:07, 1 February 2012

Comments

#Comment by Catrope (talk | contribs)   19:03, 1 February 2012

Ah, let's not hard-code these? OK for now but let's fix it later. 

+		$helpTitle = Title::newFromText( $helpPage, 'Wikipedia' );

Doesn't work, you need NS_PROJECT as the namespace.

Status & tagging log