r110444 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110443‎ | r110444 | r110445 >
Date:22:39, 31 January 2012
Author:yonishostak
Status:ok
Tags:aft 
Comment:
AFTv5: resolve bug 34079 - using the alternate solution (see comments on bug)
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -77,8 +77,8 @@
7878 'articlefeedbackv5-special-more' => 'Show more posts',
7979 'articlefeedbackv5-special-pagetitle' => 'Feedback: $1',
8080 'articlefeedbackv5-form-optionid' => 'Option $1',
81 - 'articlefeedbackv5-hidden' => 'Hidden',
82 - 'articlefeedbackv5-deleted' => 'Deleted (oversight)',
 81+ 'articlefeedbackv5-hidden' => 'This post was hidden by roll backers',
 82+ 'articlefeedbackv5-deleted' => 'This post was deleted by oversighters',
8383 'articlefeedbackv5-form-hide' => 'Hide this post',
8484 'articlefeedbackv5-form-unhide' => 'Show this post',
8585 'articlefeedbackv5-form-helpful' => 'Mark as helpful ($1)',
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -366,13 +366,13 @@
367367 .articleFeedbackv5-feedback-hidden .articleFeedbackv5-comment-wrap,
368368 .articleFeedbackv5-feedback-deleted .articleFeedbackv5-comment-wrap {
369369 opacity : 0.4;
370 - filter: alpha(opacity=40); // msie
371 - background-color: #000;
 370+ filter: alpha(opacity=40);
372371 }
373372 #articleFeedbackv5-show-feedback .articleFeedbackv5-feedback-hidden .articleFeedbackv5-feedback-hidden-marker,
374373 #articleFeedbackv5-show-feedback .articleFeedbackv5-feedback-deleted .articleFeedbackv5-feedback-deleted-marker {
375374 font-weight: bold;
376375 color: red;
377 - text-transform: uppercase;
378 - margin-left: 20px;
 376+ display: block;
 377+ clear: both;
 378+ margin-top: 10px;
379379 }
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -399,7 +399,7 @@
400400 .data( 'hidden', true );
401401 $( '<span class="articleFeedbackv5-feedback-hidden-marker"></span>' )
402402 .text( mw.msg( 'articlefeedbackv5-hidden' ) )
403 - .insertAfter( $row.find( '.articleFeedbackv5-comment-details-date a' ) );
 403+ .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
404404 };
405405
406406 // }}}
@@ -431,12 +431,8 @@
432432 $row.addClass( 'articleFeedbackv5-feedback-deleted' )
433433 .data( 'deleted', true );
434434 var $marker = $( '<span class="articleFeedbackv5-feedback-deleted-marker"></span>' )
435 - .text( mw.msg( 'articlefeedbackv5-deleted' ) );
436 - if ( $row.data( 'hidden' ) ) {
437 - $marker.insertAfter( $row.find( '.articleFeedbackv5-feedback-hidden-marker' ) );
438 - } else {
439 - $marker.insertAfter( $row.find( '.articleFeedbackv5-comment-details-date a' ) );
440 - }
 435+ .text( mw.msg( 'articlefeedbackv5-deleted' ) )
 436+ .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
441437 };
442438
443439 // }}}

Status & tagging log