r110278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110277‎ | r110278 | r110279 >
Date:11:33, 30 January 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
comment mAction / whitespaces

ping r110245
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
@@ -107,8 +107,9 @@
108108
109109 protected $mTitle;
110110 protected $mMethod = 'post';
111 -
 111+
112112 /**
 113+ * Form action URL. false means we will use the URL to set Title
113114 * @since 1.19
114115 * @var false|string
115116 */
@@ -851,19 +852,19 @@
852853 public function getLegend( $key ) {
853854 return wfMsg( "{$this->mMessagePrefix}-$key" );
854855 }
855 -
 856+
856857 /**
857858 * Set the value for the action attribute of the form.
858 - * When set to false (which is the default state), the set title is used.
859 - *
 859+ * When set to false (which is the default state), the set title is used.
 860+ *
860861 * @since 1.19
861 - *
 862+ *
862863 * @param string|false $action
863864 */
864865 public function setAction( $action ) {
865866 $this->mAction = $action;
866867 }
867 -
 868+
868869 }
869870
870871 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110245allow people to actually specify post targets with a queryjeroendedauw15:23, 29 January 2012

Comments

#Comment by Jeroen De Dauw (talk | contribs)   11:36, 30 January 2012

ping?

#Comment by Hashar (talk | contribs)   11:37, 30 January 2012

pong!

#Comment by Hashar (talk | contribs)   11:38, 30 January 2012

More seriously: that is shorter to write than 'follow-up' or contested 'FU'.

#Comment by Jeroen De Dauw (talk | contribs)   11:42, 30 January 2012

I have a fu.sh w/

svn ci -m "Follow up to r$1; $2";

Status & tagging log