r110277 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r110276‎ \| r110277 \| r110278 >
Date:	11:11, 30 January 2012
Author:	jeroendedauw
Status:	deferred
Tags:
Comment:	adding special pages for ambassador profiles and killed dead messages
Modified paths:	/trunk/extensions/EducationProgram/EducationProgram.i18n.alias.php (modified) (history) /trunk/extensions/EducationProgram/EducationProgram.i18n.php (modified) (history) /trunk/extensions/EducationProgram/EducationProgram.php (modified) (history) /trunk/extensions/EducationProgram/specials/SpecialCAProfile.php (added) (history) /trunk/extensions/EducationProgram/specials/SpecialOAProfile.php (added) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/EducationProgram.php
—	—	@@ -111,6 +111,8 @@
112	112	$wgAutoloadClasses['SpecialOAs'] = dirname( __FILE__ ) . '/specials/SpecialOAs.php';
113	113	$wgAutoloadClasses['SpecialCA'] = dirname( __FILE__ ) . '/specials/SpecialCA.php';
114	114	$wgAutoloadClasses['SpecialOA'] = dirname( __FILE__ ) . '/specials/SpecialOA.php';
	115	+$wgAutoloadClasses['SpecialOAProfile'] = dirname( __FILE__ ) . '/specials/SpecialOAProfile.php';
	116	+$wgAutoloadClasses['SpecialCAProfile'] = dirname( __FILE__ ) . '/specials/SpecialCAProfile.php';
115	117
116	118	// Special pages
117	119	$wgSpecialPages['MyCourses'] = 'SpecialMyCourses';
—	—	@@ -124,6 +126,8 @@
125	127	$wgSpecialPages['OnlineAmbassadors'] = 'SpecialOAs';
126	128	$wgSpecialPages['CampusAmbassador'] = 'SpecialCA';
127	129	$wgSpecialPages['OnlineAmbassador'] = 'SpecialOA';
	130	+$wgSpecialPages['CampusAmbassadorProfile'] = 'SpecialCAProfile';
	131	+$wgSpecialPages['OnlineAmbassadorProfile'] = 'SpecialOAProfile';
128	132
129	133	$wgSpecialPageGroups['MyCourses'] = 'education';
130	134	$wgSpecialPageGroups['Institutions'] = 'education';
—	—	@@ -134,6 +138,8 @@
135	139	$wgSpecialPageGroups['CampusAmbassadors'] = 'education';
136	140	$wgSpecialPageGroups['OnlineAmbassadors'] = 'education';
137	141	$wgSpecialPageGroups['CampusAmbassador'] = 'education';
	142	+$wgSpecialPageGroups['CampusAmbassadorProfile'] = 'education';
	143	+$wgSpecialPageGroups['OnlineAmbassadorProfile'] = 'education';
138	144
139	145	// DB object classes
140	146	$egEPDBObjects = array();
Index: trunk/extensions/EducationProgram/EducationProgram.i18n.alias.php
—	—	@@ -5,7 +5,7 @@
6	6	*
7	7	* @since 0.1
8	8	*
9		~~- * @file EducationProgram.i18n.alias.php~~
	9	+ * @file EducationProgram.alias.php
10	10	* @ingroup EducationProgram
11	11	*
12	12	* @licence GNU GPL v3+
—	—	@@ -17,22 +17,18 @@
18	18	/** English (English) */
19	19	$specialPageAliases['en'] = array(
20	20	'MyCourses' => array( 'MyCourses' ),
21		~~- 'Institution' => array( 'Institution', 'Org' ),~~
22	21	'Institutions' => array( 'Institutions', 'Orgs' ),
23	22	'Student' => array( 'Student' ),
24	23	'Students' => array( 'Students' ),
25		~~- 'Course' => array( 'Course' ),~~
26	24	'Courses' => array( 'Courses' ),
27	25	'EducationProgram' => array( 'EducationProgram' ),
28		~~- 'EditCourse' => array( 'EditCourse' ),~~
29		~~- 'EditInstitution' => array( 'EditInstitution' ),~~
30	26	'Enroll' => array( 'Enroll' ),
31	27	'CampusAmbassadors' => array( 'CampusAmbassadors' ),
32	28	'OnlineAmbassadors' => array( 'OnlineAmbassadors' ),
33	29	'CampusAmbassador' => array( 'CampusAmbassador' ),
34	30	'OnlineAmbassador' => array( 'OnlineAmbassador' ),
35		~~- 'CourseHistory' => array( 'CourseHistory' ),~~
36		~~- 'InstitutionHistory' => array( 'InstitutionHistory' ),~~
	31	+ 'OnlineAmbassadorProfile' => array( 'OnlineAmbassadorProfile' ),
	32	+ 'CampusAmbassadorProfile' => array( 'CampusAmbassadorProfile' ),
37	33	);
38	34
39	35	/** Dutch (Nederlands) */
Index: trunk/extensions/EducationProgram/specials/SpecialOAProfile.php
—	—	@@ -0,0 +1,39 @@
	2	+<?php
	3	+
	4	+/**
	5	+ * Profile page for online ambassadors.
	6	+ *
	7	+ * @since 0.1
	8	+ *
	9	+ * @file SpecialOAProfile.php
	10	+ * @ingroup EducationProgram
	11	+ *
	12	+ * @licence GNU GPL v3 or later
	13	+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
	14	+ */
	15	+class SpecialOAProfile extends SpecialEPPage {
	16	+
	17	+ /**
	18	+ * Constructor.
	19	+ *
	20	+ * @since 0.1
	21	+ */
	22	+ public function __construct() {
	23	+ parent::__construct( 'OnlineAmbassadorProfile', 'ep-online', false );
	24	+ }
	25	+
	26	+ /**
	27	+ * Main method.
	28	+ *
	29	+ * @since 0.1
	30	+ *
	31	+ * @param string $subPage
	32	+ */
	33	+ public function execute( $subPage ) {
	34	+ parent::execute( $subPage );
	35	+
	36	+
	37	+
	38	+ }
	39	+
	40	+}
\ No newline at end of file
Index: trunk/extensions/EducationProgram/specials/SpecialCAProfile.php
—	—	@@ -0,0 +1,39 @@
	2	+<?php
	3	+
	4	+/**
	5	+ * Profile page for campus ambassadors.
	6	+ *
	7	+ * @since 0.1
	8	+ *
	9	+ * @file SpecialCAProfile.php
	10	+ * @ingroup EducationProgram
	11	+ *
	12	+ * @licence GNU GPL v3 or later
	13	+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
	14	+ */
	15	+class SpecialCAProfile extends SpecialEPPage {
	16	+
	17	+ /**
	18	+ * Constructor.
	19	+ *
	20	+ * @since 0.1
	21	+ */
	22	+ public function __construct() {
	23	+ parent::__construct( 'CampusAmbassadorProfile', 'ep-campus', false );
	24	+ }
	25	+
	26	+ /**
	27	+ * Main method.
	28	+ *
	29	+ * @since 0.1
	30	+ *
	31	+ * @param string $subPage
	32	+ */
	33	+ public function execute( $subPage ) {
	34	+ parent::execute( $subPage );
	35	+
	36	+
	37	+
	38	+ }
	39	+
	40	+}
\ No newline at end of file
Index: trunk/extensions/EducationProgram/EducationProgram.i18n.php
—	—	@@ -137,24 +137,16 @@
138	138	// Special pages
139	139	'specialpages-group-education' => 'Education',
140	140	'special-mycourses' => 'My courses',
141		~~- 'special-institution' => 'Institution',~~
142	141	'special-institutions' => 'Institutions',
143	142	'special-student' => 'Student',
144	143	'special-students' => 'Students',
145		~~- 'special-course' => 'Course',~~
146	144	'special-courses' => 'Courses',
147	145	'special-educationprogram' => 'Education Program',
148		~~- 'special-editinstitution-add' => 'Add institution',~~
149		~~- 'special-editinstitution-edit' => 'Edit institution',~~
150		~~- 'special-editcourse-add' => 'Add course',~~
151		~~- 'special-editcourse-edit' => 'Edit course',~~
152	146	'special-enroll' => 'Enroll',
153	147	'special-onlineambassadors' => 'Online ambassadors',
154	148	'special-campusambassadors' => 'Campus ambassadors',
155	149	'special-onlineambassador' => 'Online ambassador',
156	150	'special-campusambassador' => 'Campus ambassador',
157		~~- 'special-coursehistory' => 'Revision history of "$1"',~~
158		~~- 'special-institutionhistory' => 'Revision history of "$1"',~~
159	151
160	152	// Course statuses
161	153	'ep-course-status-passed' => 'Passed',
—	—	@@ -238,7 +230,7 @@
239	231	// Online ambassador pager
240	232	'epstudentpager-header-user-id' => 'User',
241	233
242		~~- // Special:EditInstitution~~
	234	+ // Institution editing
243	235	'editinstitution-text' => 'Enter the institution details below and click submit to save your changes.',
244	236	'educationprogram-org-edit-name' => 'Institution name',
245	237	'editinstitution-add-legend' => 'Add institution',
—	—	@@ -247,7 +239,7 @@
248	240	'educationprogram-org-edit-country' => 'Country',
249	241	'educationprogram-org-submit' => 'Submit',
250	242
251		~~- // Special:EditCourse~~
	243	+ // Course editing
252	244	'editcourse-add-legend' => 'Add course',
253	245	'editcourse-edit-legend' => 'Edit course',
254	246	'ep-course-edit-term' => 'Term',
—	—	@@ -275,35 +267,35 @@
276	268	'ep-pager-confirm-delete-selected' => 'Are you sure you want to delete the selected {{PLURAL:$1\|item\|items}}?',
277	269	'ep-pager-delete-selected-fail' => 'Could not delete the selected {{PLURAL:$1\|item\|items}}.',
278	270
279		~~- // Special:Institution~~
	271	+ // Institution viewing
280	272	'ep-institution-none' => 'There is no institution with name "$1". See [[Special:Institution\|here]] for a list of institutions.',
281	273	'ep-institution-create' => 'There is no institution with name "$1" yet, but you can create it.',
282	274	'ep-institution-title' => 'Institution: $1',
283		~~- 'vieworgaction-summary-name' => 'Name',~~
284		~~- 'vieworgaction-summary-city' => 'City',~~
285		~~- 'vieworgaction-summary-country' => 'Country',~~
286		~~- 'vieworgaction-summary-status' => 'Status',~~
287		~~- 'vieworgaction-summary-courses' => 'Course count',~~
288		~~- 'vieworgaction-summary-students' => 'Student count',~~
	275	+ 'specialinstitution-summary-name' => 'Name',
	276	+ 'specialinstitution-summary-city' => 'City',
	277	+ 'specialinstitution-summary-country' => 'Country',
	278	+ 'specialinstitution-summary-status' => 'Status',
	279	+ 'specialinstitution-summary-courses' => 'Course count',
	280	+ 'specialinstitution-summary-students' => 'Student count',
289	281	'ep-institution-nav-edit' => 'Edit this institution',
290	282	'ep-institution-add-course' => 'Add a course',
291	283	'ep-institution-inactive' => 'Inactive',
292	284	'ep-institution-active' => 'Active',
293	285	'ep-institution-courses' => 'Courses',
294	286
295		~~- // Special:Course~~
	287	+ // Course viewing
296	288	'ep-course-title' => 'Course: $1',
297	289	'ep-course-students' => 'Students',
298	290	'ep-course-none' => 'There is no course with id "$1". See [[Special:Courses\|here]] for a list of courses.',
299	291	'ep-course-create' => 'There is no course with id "$1", but you can create a new one.',
300		~~- 'viewcourseaction-summary-org' => 'Institution',~~
301		~~- 'viewcourseaction-summary-term' => 'Term',~~
302		~~- 'viewcourseaction-summary-start' => 'Start',~~
303		~~- 'viewcourseaction-summary-end' => 'End',~~
304		~~- 'viewcourseaction-summary-students' => 'Student count',~~
305		~~- 'viewcourseaction-summary-status' => 'Status',~~
	292	+ 'specialcourse-summary-org' => 'Institution',
	293	+ 'specialcourse-summary-term' => 'Term',
	294	+ 'specialcourse-summary-start' => 'Start',
	295	+ 'specialcourse-summary-end' => 'End',
	296	+ 'specialcourse-summary-students' => 'Student count',
	297	+ 'specialcourse-summary-status' => 'Status',
306	298	'ep-course-description' => 'description',
307		~~- 'viewcourseaction-summary-token' => 'Enrollment token',~~
	299	+ 'specialcourse-summary-token' => 'Enrollment token',
308	300	'ep-course-nav-edit' => 'Edit this course',
309	301
310	302	// Special:Ambassador

Status & tagging log

13:43, 30 January 2012 😂 (talk | contribs) changed the status of r110277 [removed: new added: deferred]