r110271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110270‎ | r110271 | r110272 >
Date:08:45, 30 January 2012
Author:liangent
Status:reverted
Tags:
Comment:
Drop a comment. We'll never turn to variant-as-2nd-arg because of r109161.
Modified paths:
  • /trunk/extensions/FeaturedFeeds/FeaturedFeeds.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FeaturedFeeds/FeaturedFeeds.body.php
@@ -365,7 +365,6 @@
366366 if ( $wgContLang->hasVariants() && $this->variant ) {
367367 $text = $wgContLang->mConverter->convertTo( $text, $this->variant );
368368 $entry = $wgContLang->mConverter->convertTo( $entry, $this->variant );
369 - // bug 34010. otherwise variant specified in the second argument can be ignored.
370369 $url = $special->getFullURL( array( 'variant' => $this->variant ) );
371370 } else {
372371 $url = $special->getFullURL();

Follow-up revisions

RevisionCommit summaryAuthorDate
r110478*temporary* revert of r110207 and r110271, will recommit with my fixes latermaxsem14:22, 1 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109161deprecated $query2 in Title.php...hashar16:42, 17 January 2012

Status & tagging log