r110272 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110271‎ | r110272 | r110273 >
Date:09:22, 30 January 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added class docs
Modified paths:
  • /trunk/extensions/EducationProgram/EducationProgram.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/CourseHistoryAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPEditAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPHistoryAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPViewAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EditCourseAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EditOrgAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/OrgHistoryAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/ViewCourseAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/ViewOrgAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/api/ApiDeleteEducation.php (modified) (history)
  • /trunk/extensions/EducationProgram/api/ApiInstructor.php (modified) (history)
  • /trunk/extensions/EducationProgram/api/ApiRefreshEducation.php (modified) (history)
  • /trunk/extensions/EducationProgram/pages/CoursePage.php (modified) (history)
  • /trunk/extensions/EducationProgram/pages/EPPage.php (modified) (history)
  • /trunk/extensions/EducationProgram/pages/OrgPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/EducationProgram.php
——@@ -305,6 +305,7 @@
306306 'ep.api.js',
307307 ),
308308 'dependencies' => array(
 309+ 'mediawiki.user',
309310 'ep.core',
310311 ),
311312 );
——@@ -381,6 +382,7 @@
382383 'ep.instructor.js',
383384 ),
384385 'dependencies' => array(
 386+ 'mediawiki.user',
385387 'jquery.ui.dialog',
386388 'ep.core',
387389 'ep.api',
Index: trunk/extensions/EducationProgram/pages/CoursePage.php
——@@ -1,7 +1,17 @@
22 <?php
33
4 -
5 -
 4+/**
 5+ * Page for interacting with a course.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file CoursePage.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Page
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
616 class CoursePage extends EPPage {
717
818 protected function getActions() {
Index: trunk/extensions/EducationProgram/pages/EPPage.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Abstract Page for interacting with a EPDBObject.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EPPage.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Page
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 abstract class EPPage extends Page implements IContextSource {
517
618 protected $context;
——@@ -9,6 +21,10 @@
1022 $this->page = new WikiPage( $title );
1123 }
1224
 25+ public function view() {
 26+ // MediaWiki::articleFromTitle($title, $context)
 27+ }
 28+
1329 public function setContext( IContextSource $context ) {
1430 $this->context = $context;
1531 }
Index: trunk/extensions/EducationProgram/pages/OrgPage.php
——@@ -1,6 +1,17 @@
22 <?php
33
4 -
 4+/**
 5+ * Page for interacting with an org.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file OrgPage.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Page
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
516 class OrgPage extends EPPage {
617
718 protected function getActions() {
Index: trunk/extensions/EducationProgram/actions/ViewCourseAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action for viewing a course.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file ViewCourseAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class ViewCourseAction extends EPViewAction {
517
618 public function getName() {
Index: trunk/extensions/EducationProgram/actions/EditOrgAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action to edit an org.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EditOrgAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class EditOrgAction extends EPEditAction {
517
618
Index: trunk/extensions/EducationProgram/actions/EPViewAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Abstract action for viewing EPDBObject items.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EPViewAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 abstract class EPViewAction extends FormlessAction {
517
618 /**
Index: trunk/extensions/EducationProgram/actions/CourseHistoryAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action to view the history of courses.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file CourseHistoryAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class CourseHistoryAction extends EPHistoryAction {
517
618
Index: trunk/extensions/EducationProgram/actions/ViewOrgAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action for viewing an org.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file ViewOrgAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class ViewOrgAction extends EPViewAction {
517
618 public function getName() {
Index: trunk/extensions/EducationProgram/actions/EPHistoryAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Abstract action for viewing the history of EPDBObject items.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EPHistoryAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 abstract class EPHistoryAction extends FormlessAction {
517
618 protected abstract function getItemClass();
Index: trunk/extensions/EducationProgram/actions/EditCourseAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action to edit a course.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EditCourseAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class EditCourseAction extends EPEditAction {
517
618
Index: trunk/extensions/EducationProgram/actions/OrgHistoryAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Action to view the history of orgs.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file OrgHistoryAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 class OrgHistoryAction extends EPHistoryAction {
517
618
Index: trunk/extensions/EducationProgram/actions/EPEditAction.php
——@@ -1,5 +1,17 @@
22 <?php
33
 4+/**
 5+ * Abstract action for editing EPDBObject items.
 6+ *
 7+ * @since 0.1
 8+ *
 9+ * @file EPEditAction.php
 10+ * @ingroup EducationProgram
 11+ * @ingroup Action
 12+ *
 13+ * @licence GNU GPL v3+
 14+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 15+ */
416 abstract class EPEditAction extends FormlessAction {
517
618 /**
Index: trunk/extensions/EducationProgram/api/ApiRefreshEducation.php
——@@ -6,7 +6,7 @@
77 * @since 0.1
88 *
99 * @file ApiRefreshEducation.php
10 - * @ingroup Education Program
 10+ * @ingroup EducationProgram
1111 * @ingroup API
1212 *
1313 * @licence GNU GPL v3+
Index: trunk/extensions/EducationProgram/api/ApiInstructor.php
——@@ -6,7 +6,7 @@
77 * @since 0.1
88 *
99 * @file ApiInstructor.php
10 - * @ingroup Education Program
 10+ * @ingroup EducationProgram
1111 * @ingroup API
1212 *
1313 * @licence GNU GPL v3+
Index: trunk/extensions/EducationProgram/api/ApiDeleteEducation.php
——@@ -6,7 +6,7 @@
77 * @since 0.1
88 *
99 * @file ApiDeleteEducation.php
10 - * @ingroup Education Program
 10+ * @ingroup EducationProgram
1111 * @ingroup API
1212 *
1313 * @licence GNU GPL v3+

Status & tagging log