r110070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110069‎ | r110070 | r110071 >
Date:19:56, 26 January 2012
Author:gregchiasson
Status:resolved (Comments)
Tags:aft 
Comment:
ATF5 - fix issues from r109258 (not calling text() on messages) - one of the messages is gone, so that's been removed from here and from the english translation (it was never in the qqq translation to begin with), and the other is going through text() (cant use plain because it has a plural in it). The comment about the date issue was resolved as part of the changes to date display in r110068
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -71,7 +71,6 @@
7272 'articlefeedbackv5-special-filter-label-before' => 'Showing:',
7373 'articlefeedbackv5-special-filter-label-after' => '',
7474 'articlefeedbackv5-special-showing' => '{{PLURAL:$1|1 feedback post|$1 feedback posts }} on this article',
75 - 'articlefeedbackv5-comment-link' => 'Permalink',
7675 'articleFeedbackv5-comment-ago' => '$1 ago',
7776 'articlefeedbackv5-updates-since' => '{{PLURAL:$1|1 edit|$1 edits}} since post',
7877 'articlefeedbackv5-special-more' => 'Show more posts',
Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -322,7 +322,7 @@
323323 if( $record[0]->age > 0 ) {
324324 $details .= Linker::link(
325325 Title::newFromText( $record[0]->page_title ),
326 - wfMessage( 'articlefeedbackv5-updates-since', $record[0]->age ),
 326+ wfMessage( 'articlefeedbackv5-updates-since', $record[0]->age )->text(),
327327 array(),
328328 array(
329329 'action' => 'historysubmit',

Follow-up revisions

RevisionCommit summaryAuthorDate
r110132Fixes issues raised in commits from last night:...gregchiasson15:57, 27 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109258AFT5 - more HTML chanesgregchiasson00:23, 18 January 2012
r110068AFT5:...gregchiasson19:23, 26 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:28, 27 January 2012

Actually you need ->escaped() here, since the second parameter to ::link should be escaped.

Status & tagging log