r110069 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110068‎ | r110069 | r110070 >
Date:19:41, 26 January 2012
Author:gregchiasson
Status:resolved (Comments)
Tags:aft 
Comment:
AFT5 - explicitly declare this as plain, per comments on r109390
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -142,7 +142,7 @@
143143 'div',
144144 array( 'id' => 'articleFeedbackv5-percent-found-wrap' )
145145 )
146 - . $this->msg( 'articlefeedbackv5-percent-found', $found ) # Can't escape this, need the <span> tag to parse.
 146+ . $this->msg( 'articlefeedbackv5-percent-found', $found )->plain() # Can't escape this, need the <span> tag to parse.
147147 . Html::closeElement( 'div' )
148148 );
149149 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r110132Fixes issues raised in commits from last night:...gregchiasson15:57, 27 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109390Fix AFT5 special page translation again - looks like it got clobbered in r109...gregchiasson16:46, 18 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:32, 27 January 2012

Wasn't the span thing supposed to be temporary? You could pass $found in ->rawParams() and move the span outside of the message itself.

Status & tagging log