r109971 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r109970‎ \| r109971 \| r109972 >
Date:	00:28, 25 January 2012
Author:	gregchiasson
Status:	resolved (Comments)
Tags:
Comment:	ATF5 - fix image links on sort arrows, and a couple of the queries for building the filterCount rollup table.
Modified paths:	/trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history) /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history) /trunk/extensions/ArticleFeedbackv5/sql/alter.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/sql/alter.sql
—	—	@@ -68,12 +68,12 @@
69	69	-- added or updated 1/24 (greg)
70	70	DELETE FROM aft_article_filter_count;
71	71	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'helpful', COUNT(*) FROM aft_article_feedback WHERE CONVERT(af_helpful_count, SIGNED) - CONVERT(af_unhelpful_count, SIGNED) > 0 GROUP BY af_page_id;
72		~~-INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'abusive', COUNT(*) FROM aft_article_feedback WHERE af_abuse_count = 0 GROUP BY af_page_id;~~
	72	+INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'abusive', COUNT(*) FROM aft_article_feedback WHERE af_abuse_count > 0 GROUP BY af_page_id;
73	73	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'invisible', COUNT(*) FROM aft_article_feedback WHERE af_hide_count > 0 GROUP BY af_page_id;
74	74	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'visible', COUNT(*) FROM aft_article_feedback WHERE af_hide_count = 0 GROUP BY af_page_id;
75	75	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'all', COUNT(*) FROM aft_article_feedback GROUP BY af_page_id;
76	76	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'comment', COUNT(*) FROM aft_article_feedback, aft_article_answer WHERE af_id = aa_feedback_id AND aa_response_text IS NOT NULL GROUP BY af_page_id;
77	77	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'deleted', COUNT(*) FROM aft_article_feedback WHERE af_delete_count > 0 GROUP BY af_page_id;
78	78	INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'unhelpful', COUNT(*) FROM aft_article_feedback WHERE CONVERT(af_helpful_count, SIGNED) - CONVERT(af_unhelpful_count, SIGNED) < 0 GROUP BY af_page_id;
	79	+INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'needsoversight', COUNT(*) FROM aft_article_feedback WHERE af_needs_oversight IS TRUE GROUP BY af_page_id;
79	80	ALTER TABLE aft_article_feedback ADD COLUMN af_needs_oversight boolean NOT NULL DEFAULT FALSE;
80		-INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'needsoversight', COUNT(*) FROM aft_article_feedback WHERE af_needs_oversight IS TRUE GROUP BY af_page_id;
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
—	—	@@ -293,4 +293,4 @@
294	294	#articleFeedbackv5-sort .articleFeedbackv5-sort-arrow {
295	295	font-weight: bold;
296	296	color: #0645AD;
297		-}
\ No newline at end of file
	297	+}
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
—	—	@@ -164,7 +164,7 @@
165	165
166	166	$( '#articleFeedbackv5-sort-arrow-' + id ).show();
167	167	$( '#articleFeedbackv5-sort-arrow-' + id ).attr(
168		~~- 'src', 'images/sort ' + dir + 'ending.png'~~
	168	+ 'src', '/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/sort-' + dir + 'ending.png'
169	169	);
170	170	$( '#articleFeedbackv5-special-sort-' + id).addClass( 'sort-active' );
171	171	}

Follow-up revisions

Revision	Commit summary	Author	Date
r110611	AFT5: Use wgExtensionAssetsPath, which refs r109971, and make the more button...	gregchiasson	20:37, 2 February 2012

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r109390	Fix AFT5 special page translation again - looks like it got clobbered in r109...	gregchiasson	16:46, 18 January 2012

Comments

#Comment by Johnduhart (talk | contribs) 00:34, 25 January 2012

+			'src', '/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/sort-' + dir + 'ending.png'

Should be using wgExtensionAssetsPath for that, which should really be a div with a backaground-image

Status & tagging log

01:28, 13 June 2012 Krinkle (talk | contribs) changed the tags for r109971 [removed: nodeploy]
00:09, 28 February 2012 Catrope (talk | contribs) changed the status of r109971 [removed: new added: resolved]
20:42, 2 February 2012 Gregchiasson (talk | contribs) changed the status of r109971 [removed: fixme added: new]
23:51, 26 January 2012 MarkAHershberger (talk | contribs) changed the tags for r109971 [added: nodeploy]
00:34, 25 January 2012 Johnduhart (talk | contribs) changed the status of r109971 [removed: new added: fixme]