r109972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109971‎ | r109972 | r109973 >
Date:00:36, 25 January 2012
Author:gregchiasson
Status:ok
Tags:aft 
Comment:
AFT5 feedback page - 'X feedback posts on this article' should always show the total. There's a known issue here, which is that the total for a logged in user isn't the same as the total for an editor, which isn't the same as the total for an oversighter, but that will require new rows in the rollup table - for now, at least remove the manual filtering.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -32,7 +32,7 @@
3333 $pageId = $params['pageid'];
3434 $html = '';
3535 $length = 0;
36 - $count = $this->fetchFeedbackCount( $params['pageid'], $params['filter'], $params['filtervalue'] );
 36+ $count = $this->fetchFeedbackCount( $params['pageid'] );
3737 $feedback = $this->fetchFeedback(
3838 $params['pageid'],
3939 $params['filter'],
@@ -58,14 +58,14 @@
5959 }
6060 }
6161
62 - public function fetchFeedbackCount( $pageId, $filter, $filterValue ) {
 62+ public function fetchFeedbackCount( $pageId ) {
6363 $dbr = wfGetDB( DB_SLAVE );
6464 $count = $dbr->selectField(
6565 array( 'aft_article_filter_count' ),
6666 array( 'afc_filter_count' ),
6767 array(
6868 'afc_page_id' => $pageId,
69 - 'afc_filter_name' => $filter
 69+ 'afc_filter_name' => 'all'
7070 ),
7171 __METHOD__
7272 );

Sign-offs

UserFlagDate
Johnduhartinspected00:37, 25 January 2012

Status & tagging log