r109729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109728‎ | r109729 | r109730 >
Date:12:53, 22 January 2012
Author:foxtrott
Status:deferred (Comments)
Tags:
Comment:
fix for r108226 - removed stray single-quote; partial undo
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -6,30 +6,30 @@
77 */
88
99 // initialise
10 -jQuery( function( $ ) {
 10+jQuery( function() {
1111
1212 // register eventhandlers on 'edit' links and buttons
1313
1414 // register formlink with link
15 - $('a.popupformlink').click(function(evt){
 15+ jQuery('a.popupformlink').click(function(evt){
1616 return ext.popupform.handlePopupFormLink( this.getAttribute('href'), this );
1717 });
1818
1919 // register formlink with button
20 - $( 'form.popupformlink' ).submit(function(evt){
 20+ jQuery( 'form.popupformlink' ).submit(function(evt){
2121 return ext.popupform.handlePopupFormLink( this.getAttribute( 'action' ), this );
2222 });
2323
2424
2525 // register forminput
26 - $( 'form.popupforminput' ).submit(function(evt){
 26+ jQuery( 'form.popupforminput' ).submit(function(evt){
2727 return ext.popupform.handlePopupFormInput( this.getAttribute( 'action' ), this );
2828 });
2929
3030 });
3131
3232 // create ext if it does not exist yet
33 -if ( typeof( window.ext' ) === "undefined" ) {
 33+if ( typeof( window.ext ) === "undefined" ) {
3434 window.ext = {};
3535 }
3636

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108226Some quick untested cleanups to this JSnikerabbit12:36, 6 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   14:28, 22 January 2012

Surely it is easier to remove one character from the file than to revert the whole file?

#Comment by F.trott (talk | contribs)   14:38, 22 January 2012

Did it by hand, did not even realize I reverted the whole file.