r109730 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109729‎ | r109730 | r109731 >
Date:13:02, 22 January 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Don't force message groups to implement getBools, getTags is the official way to do this
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -257,9 +257,9 @@
258258 $defs = new MessageDefinitions( $definitions, $this->namespaces[0] );
259259 $collection = MessageCollection::newFromDefinitions( $defs, $code );
260260
261 - $bools = $this->getBools();
262 - $collection->setTags( 'ignored', $bools['ignored'] );
263 - $collection->setTags( 'optional', $bools['optional'] );
 261+ foreach ( $this->getTags() as $type => $tags ) {
 262+ $collection->setTags( $type, $tags );
 263+ }
264264
265265 return $collection;
266266 }

Status & tagging log