r108862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108861‎ | r108862 | r108863 >
Date:22:09, 13 January 2012
Author:hashar
Status:ok (Comments)
Tags:hexmode 
Comment:
XCF: force rendering

Browsers do not support GIMP native format (yet?!). So we really need
to force rendering.
Noticed by Mark while testing the feature on labs.

Follow r107351
Modified paths:
  • /trunk/phase3/includes/media/XCF.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/XCF.php
@@ -20,6 +20,14 @@
2121 class XCFHandler extends BitmapHandler {
2222
2323 /**
 24+ * @param $file
 25+ * @return bool
 26+ */
 27+ function mustRender( $file ) {
 28+ return true;
 29+ }
 30+
 31+ /**
2432 * Render files as PNG
2533 *
2634 * @param $ext

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107351* First simple XCF thumbnailing. Convert from ImageMagick has buggy...mah00:46, 27 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   22:24, 13 January 2012
+	 * @param $file

Really? Is that useful.

Status & tagging log