r108861 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108860‎ | r108861 | r108862 >
Date:22:02, 13 January 2012
Author:aaron
Status:ok
Tags:
Comment:
* Fix another missing hypen (broken since api was added most likely)
* Removed commented out code
Modified paths:
  • /trunk/extensions/CheckUser/api/ApiQueryCheckUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/api/ApiQueryCheckUser.php
@@ -54,7 +54,6 @@
5555 foreach ( $res as $row ) {
5656 $timestamp = wfTimestamp( TS_ISO_8601, $row->cuc_timestamp );
5757 $ip = strval( $row->cuc_ip );
58 - //$xff = $row->cuc_xff;
5958
6059 if ( !isset( $ips[$ip] ) ) {
6160 $ips[$ip]['end'] = $timestamp;
@@ -141,7 +140,7 @@
142141 $this->addWhere( $cond );
143142 $log_type = 'ipusers';
144143 if ( isset( $xff ) ) {
145 - $log_type .= 'xff';
 144+ $log_type .= '-xff';
146145 }
147146 } else {
148147 $this->dieUsage( 'IP or range is invalid', 'invalidip' );

Status & tagging log