r108854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108853‎ | r108854 | r108855 >
Date:21:48, 13 January 2012
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Fix missing log_type

Worked out from the code in doIPUsersRequest

<pre>
$logType = 'ipusers';
if ( $xfor ) {
$logType .= '-xff';
}
</pre>
Modified paths:
  • /trunk/extensions/CheckUser/api/ApiQueryCheckUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/api/ApiQueryCheckUser.php
@@ -140,6 +140,7 @@
141141 if ( IP::isIPAddress( $target ) && isset( $xff ) ) {
142142 $cond = CheckUser::getIpConds( $db, $target, true );
143143 $this->addWhere( $cond );
 144+ $log_type = 'ipusersxff';
144145 } elseif ( IP::isIPAddress( $target ) ) {
145146 $cond = CheckUser::getIpConds( $db, $target );
146147 $this->addWhere( $cond );
@@ -275,4 +276,4 @@
276277 public function getVersion() {
277278 return __CLASS__ . ': $Id$';
278279 }
279 -}
\ No newline at end of file
 280+}

Comments

#Comment by Reedy (talk | contribs)   21:52, 13 January 2012

Follows up where it was added in r100165

Status & tagging log