r108853 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108852‎ | r108853 | r108854 >
Date:21:42, 13 January 2012
Author:reedy
Status:ok
Tags:
Comment:
() are valid in URLs, not sure why we're using them as a finishing point in ApiFormatBase

Fixes fixme on r95572 as urls are now complete with () in them
Modified paths:
  • /trunk/phase3/includes/api/ApiFormatBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFormatBase.php
@@ -264,7 +264,7 @@
265265 // This regex hacks around bug 13218 (" included in the URL)
266266 $text = preg_replace( "#(($protos).*?)(&quot;)?([ \\'\"<>\n]|&lt;|&gt;|&quot;)#", '<a href="\\1">\\1</a>\\3\\4', $text );
267267 // identify requests to api.php
268 - $text = preg_replace( "#api\\.php\\?[^ \\()<\n\t]+#", '<a href="\\0">\\0</a>', $text );
 268+ $text = preg_replace( "#api\\.php\\?[^ <\n\t]+#", '<a href="\\0">\\0</a>', $text );
269269 if ( $this->mHelp ) {
270270 // make strings inside * bold
271271 $text = preg_replace( "#\\*[^<>\n]+\\*#", '<b>\\0</b>', $text );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95572Adds ResourceLoader support to AbuseFilter...johnduhart20:12, 26 August 2011

Status & tagging log