r108720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108719‎ | r108720 | r108721 >
Date:12:51, 12 January 2012
Author:maxsem
Status:resolved (Comments)
Tags:
Comment:
Follow-up r108549: {{PLURAL}}
Modified paths:
  • /trunk/extensions/GeoData/CoordinatesParserFunction.php (modified) (history)
  • /trunk/extensions/GeoData/GeoData.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GeoData/CoordinatesParserFunction.php
@@ -108,7 +108,10 @@
109109 return Status::newFatal( '' );
110110 }
111111 $geoData->limitExceeded = true;
112 - return Status::newFatal( 'geodata-limit-exceeded', $wgContLang->formatNum( $wgMaxCoordinatesPerPage ) );
 112+ return Status::newFatal( 'geodata-limit-exceeded',
 113+ $wgContLang->formatNum( $wgMaxCoordinatesPerPage ),
 114+ $wgMaxCoordinatesPerPage
 115+ );
113116 }
114117 if ( $coord->primary ) {
115118 if ( $geoData->getPrimary() ) {
Index: trunk/extensions/GeoData/GeoData.i18n.php
@@ -15,7 +15,7 @@
1616 'geodata-bad-longitude' => '<nowiki>{{#coordinates:}}</nowiki>: invalid longitude',
1717 'geodata-bad-region' => '<nowiki>{{#coordinates:}}</nowiki>: invalid region code format',
1818 'geodata-multiple-primary' => '<nowiki>{{#coordinates:}}</nowiki>: cannot have more than one primary tag per page',
19 - 'geodata-limit-exceeded' => 'The limit of $1 <nowiki>{{#coordinates:}}</nowiki> tags per page has been exceeded',
 19+ 'geodata-limit-exceeded' => 'The limit of $1 <nowiki>{{#coordinates:}}</nowiki> {{PLURAL:$2|tag|tags}} per page has been exceeded',
2020 'geodata-broken-tags-category' => 'Pages with malformed coordinate tags',
2121 'geodata-primary-coordinate' => 'primary',
2222 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r108721Fix r108720: No need to introduce &2...raymond13:23, 12 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108549Added localisationmaxsem21:01, 10 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   13:06, 12 January 2012

You don't and shouldn't pass the number twice. Plural expects formatted numbers.

Status & tagging log