r108721 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108720‎ | r108721 | r108722 >
Date:13:23, 12 January 2012
Author:raymond
Status:ok
Tags:
Comment:
Fix r108720: No need to introduce &2
Consistency tweaks in preparation for adding extension to translatewiki.net
Modified paths:
  • /trunk/extensions/GeoData/CoordinatesParserFunction.php (modified) (history)
  • /trunk/extensions/GeoData/GeoData.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GeoData/CoordinatesParserFunction.php
@@ -109,8 +109,7 @@
110110 }
111111 $geoData->limitExceeded = true;
112112 return Status::newFatal( 'geodata-limit-exceeded',
113 - $wgContLang->formatNum( $wgMaxCoordinatesPerPage ),
114 - $wgMaxCoordinatesPerPage
 113+ $wgContLang->formatNum( $wgMaxCoordinatesPerPage )
115114 );
116115 }
117116 if ( $coord->primary ) {
Index: trunk/extensions/GeoData/GeoData.i18n.php
@@ -8,6 +8,9 @@
99
1010 $messages = array();
1111
 12+/** English
 13+ * @author Max Semenik
 14+ */
1215 $messages['en'] = array(
1316 'geodata-desc' => 'Adds geographical coordinates storage and retrieval functionality.',
1417 'geodata-bad-input' => 'Invalid arguments have been passed to the <nowiki>{{#coordinates:}}</nowiki> function',
@@ -15,11 +18,14 @@
1619 'geodata-bad-longitude' => '<nowiki>{{#coordinates:}}</nowiki>: invalid longitude',
1720 'geodata-bad-region' => '<nowiki>{{#coordinates:}}</nowiki>: invalid region code format',
1821 'geodata-multiple-primary' => '<nowiki>{{#coordinates:}}</nowiki>: cannot have more than one primary tag per page',
19 - 'geodata-limit-exceeded' => 'The limit of $1 <nowiki>{{#coordinates:}}</nowiki> {{PLURAL:$2|tag|tags}} per page has been exceeded',
 22+ 'geodata-limit-exceeded' => 'The limit of $1 <nowiki>{{#coordinates:}}</nowiki> {{PLURAL:$1|tag|tags}} per page has been exceeded',
2023 'geodata-broken-tags-category' => 'Pages with malformed coordinate tags',
2124 'geodata-primary-coordinate' => 'primary',
2225 );
2326
 27+/** Message documentation (Message documentation)
 28+ * @author Max Semenik
 29+ */
2430 $messages['qqq'] = array(
2531 'geodata-desc' => '{{desc}}',
2632 'geodata-limit-exceeded' => '$1 is a number',
@@ -27,6 +33,9 @@
2834 'geodata-primary-coordinate' => 'Localised name of parameter that makes <nowiki>{{#coordinates:}}</nowiki> tag primary',
2935 );
3036
 37+/** Russian (Русский)
 38+ * @author Max Semenik
 39+ */
3140 $messages['ru'] = array(
3241 'geodata-multiple-primary' => '<nowiki>{{#coordinates:}}</nowiki>: нельзя иметь более одной первичной метки на странице',
33 -);
\ No newline at end of file
 42+);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108720Follow-up r108549: {{PLURAL}}maxsem12:51, 12 January 2012

Status & tagging log