r108693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108692‎ | r108693 | r108694 >
Date:22:52, 11 January 2012
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Make some things conditional for <= 1.17
Modified paths:
  • /trunk/tools/make-release/make-release (modified) (history)

Diff [purge]

Index: trunk/tools/make-release/make-release
@@ -208,7 +208,10 @@
209209 export(branch, package)
210210
211211 # Export extensions for inclusion
212 - extensions = ['ConfirmEdit', 'Gadgets', 'Nuke', 'ParserFunctions', 'Renameuser', 'Vector', 'WikiEditor']
 212+ if dir <= '1.17':
 213+ extensions = ['ConfirmEdit', 'Gadgets', 'Nuke', 'ParserFunctions', 'Renameuser', 'Vector', 'WikiEditor']
 214+ else:
 215+ extensions = []
213216 for ext in extensions:
214217 exportExtension(branch, ext, package)
215218
@@ -267,7 +270,10 @@
268271 # Write email template
269272 print
270273 print "Full release notes:"
271 - print 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES-' + dir
 274+ if dir <= '1.17':
 275+ print 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES'
 276+ else:
 277+ print 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES-' + dir
272278 print 'https://www.mediawiki.org/wiki/Release_notes/' + dir
273279 print
274280 print

Follow-up revisions

RevisionCommit summaryAuthorDate
r108736Simplify r108693...reedy17:52, 12 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:20, 12 January 2012

Is the first condition flipped?

#Comment by Reedy (talk | contribs)   17:52, 12 January 2012

Lol, yup. Fixed

Status & tagging log