r108736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108735‎ | r108736 | r108737 >
Date:17:52, 12 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Simplify r108693

Also fix stupid logic error noticed by Niklas
Modified paths:
  • /trunk/tools/make-release/make-release (modified) (history)

Diff [purge]

Index: trunk/tools/make-release/make-release
@@ -208,10 +208,10 @@
209209 export(branch, package)
210210
211211 # Export extensions for inclusion
212 - if dir <= '1.17':
 212+ extensions = []
 213+ if dir > '1.17':
213214 extensions = ['ConfirmEdit', 'Gadgets', 'Nuke', 'ParserFunctions', 'Renameuser', 'Vector', 'WikiEditor']
214 - else:
215 - extensions = []
 215+
216216 for ext in extensions:
217217 exportExtension(branch, ext, package)
218218
@@ -270,10 +270,11 @@
271271 # Write email template
272272 print
273273 print "Full release notes:"
274 - if dir <= '1.17':
275 - print 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES'
276 - else:
277 - print 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES-' + dir
 274+ url = 'https://svn.wikimedia.org/svnroot/mediawiki/' + branch + '/phase3/RELEASE-NOTES'
 275+ if dir > '1.17':
 276+ url += '-' + dir
 277+
 278+ print url
278279 print 'https://www.mediawiki.org/wiki/Release_notes/' + dir
279280 print
280281 print

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108693Make some things conditional for <= 1.17reedy22:52, 11 January 2012

Status & tagging log