r108665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108664‎ | r108665 | r108666 >
Date:20:04, 11 January 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Bringing back the bit that properly handled db errors
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2548,7 +2548,12 @@
25492549 } else {
25502550 var msg;
25512551 if ( 'error' in data ) {
2552 - msg = mw.msg( data.error );
 2552+ if ( typeof( data.error ) == 'object' ) {
 2553+ msg = data.error;
 2554+ } else {
 2555+ msg = mw.msg( data.error );
 2556+ }
 2557+ aft5_debug( data.error );
25532558 } else {
25542559 msg = { info: mw.msg( 'articlefeedbackv5-error-unknown' ) };
25552560 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1086661.18wmf1: Updating to trunk state to pick up r108665catrope20:08, 11 January 2012

Status & tagging log