r108666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108665‎ | r108666 | r108667 >
Date:20:08, 11 January 2012
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: Updating to trunk state to pick up r108665
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5 (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2548,7 +2548,12 @@
25492549 } else {
25502550 var msg;
25512551 if ( 'error' in data ) {
2552 - msg = mw.msg( data.error );
 2552+ if ( typeof( data.error ) == 'object' ) {
 2553+ msg = data.error;
 2554+ } else {
 2555+ msg = mw.msg( data.error );
 2556+ }
 2557+ aft5_debug( data.error );
25532558 } else {
25542559 msg = { info: mw.msg( 'articlefeedbackv5-error-unknown' ) };
25552560 }
Property changes on: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
___________________________________________________________________
Modified: svn:mergeinfo
25562561 Merged /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php:r108658-108665
Property changes on: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5
___________________________________________________________________
Modified: svn:mergeinfo
25572562 Merged /trunk/extensions/ArticleFeedbackv5:r108658-108665

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108665Bringing back the bit that properly handled db errorsrsterbin20:04, 11 January 2012

Status & tagging log