r108642 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108641‎ | r108642 | r108643 >
Date:17:57, 11 January 2012
Author:rmoen
Status:ok (Comments)
Tags:
Comment:
follow up to concurrency tool revert, remove dependant code. follow up r108600
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -413,8 +413,7 @@
414414 $( '.fbd-response-preview, .fbd-response-submit' ).removeProp( 'disabled' );
415415 $( this ).find( '.fbd-response-form' ).remove();
416416 }
417 - //remove ConcurrencyToolTip if any
418 - $( this ).find( '.fbd-tooltip-overlay-wrap').remove();
 417+
419418 });
420419 }
421420
@@ -540,17 +539,6 @@
541540 wikitext = wikitext.replace( /~{3,5}/g, '' ) + "\n\n~~~~"; // Remove and add signature for
542541 parseWikiText( $item, wikitext );
543542 });
544 -
545 - //run concurrency check
546 - $.concurrency.check( {
547 - ccaction: 'checkout',
548 - resourcetype: 'moodbar-feedback-response',
549 - record: $item.data( 'mbccontinue' ).split( '|' )[1]
550 - }, function( data ){
551 - if( data && data.concurrency.result == 'failure' ) { //checkout failed, show tooltip
552 - loadConcurrencyToolTip($item);
553 - }
554 - } );
555543 }
556544 e.preventDefault();
557545 }
@@ -637,38 +625,6 @@
638626 }, 2000);
639627 }
640628
641 - /**
642 - * Display tooltip for response concurrency notification
643 - * @param $item Feedback item
644 - */
645 - function loadConcurrencyToolTip($item) {
646 - var $tooltip = $('<div>').attr('class', 'fbd-tooltip-overlay-wrap')
647 - .append(
648 - $('<div>').attr('class', 'fbd-tooltip-overlay')
649 - .append(
650 - $('<div>').attr('class', 'fbd-tooltip-pointy')
651 - ).append(
652 - $('<div>').attr('class', 'fbd-tooltip-title')
653 - .text( mw.msg( 'response-concurrency-notification' ) )
654 - .prepend(
655 - $('<span>').attr('class', 'fbd-tooltip-close').text('X')
656 - )
657 - )
658 - );
659 - $item.find( '.fbd-item-response' ).append( $tooltip );
660 - // Close event, closure remembers object
661 - $( '.fbd-tooltip-close' )
662 - .live( 'click' , function () {
663 - $tooltip.remove();
664 - } );
665 - setTimeout( function() {
666 - $tooltip.fadeOut( function(){
667 - $tooltip.remove();
668 - } );
669 - }, 1500 );
670 -
671 - }
672 -
673629 // On-load stuff
674630 $( '.fbd-item-show a' ).live( 'click', showHiddenItem );
675631 $( '.fbd-item-hide a' ).live( 'click', hideItem );
Index: trunk/extensions/MoodBar/MoodBar.php
@@ -189,7 +189,6 @@
190190 'scripts' => 'ext.moodBar.dashboard/ext.moodBar.dashboard.js',
191191 'dependencies' => array(
192192 'mediawiki.util',
193 - 'jquery.concurrency',
194193 'user.tokens',
195194 'jquery.NobleCount',
196195 'jquery.elastic'

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108600Add some top padding to avoid text with large font size not touching the tool...santhosh08:31, 11 January 2012

Comments

#Comment by Santhosh.thottingal (talk | contribs)   17:58, 11 January 2012

r108600 is not related to this. It is webfonts extension fix.

#Comment by Robmoen (talk | contribs)   18:08, 11 January 2012

oops, follow up to r108601

Status & tagging log